From: Pavel Machek <pavel@ucw.cz>
To: Stefan Agner <stefan@agner.ch>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Sakari Ailus <sakari.ailus@iki.fi>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Fengguang Wu <fengguang.wu@intel.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Revert "[media] et8ek8: Export OF device ID as module aliases"
Date: Mon, 7 Aug 2017 13:09:07 +0200 [thread overview]
Message-ID: <20170807110907.GA28655@amd> (raw)
In-Reply-To: <aae480c52bd7e9e4772b3c9c76420435@agner.ch>
[-- Attachment #1: Type: text/plain, Size: 1650 bytes --]
Hi!
> Just hit this issue too. This seems not to have made it into v4.13 as of
> today yet, any chance to get it still in?
If Mauro does not react, I guess we can push the patche through
akpm. Hmm. Or directly to the Linus. -rc really is about fixing
regressions, such as this.
Best regards,
Pavel
> --
> Stefan
>
> On 2017-06-08 02:01, Arnd Bergmann wrote:
> > This one got applied twice, causing a build error with clang:
> >
> > drivers/media/i2c/et8ek8/et8ek8_driver.c:1499:1: error: redefinition
> > of '__mod_of__et8ek8_of_table_device_table'
> >
> > Fixes: 9ae05fd1e791 ("[media] et8ek8: Export OF device ID as module aliases")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Acked-by: Pavel Machek <pavel@ucw.cz>
> > ---
> > drivers/media/i2c/et8ek8/et8ek8_driver.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c
> > b/drivers/media/i2c/et8ek8/et8ek8_driver.c
> > index 6e313d5243a0..f39f5179dd95 100644
> > --- a/drivers/media/i2c/et8ek8/et8ek8_driver.c
> > +++ b/drivers/media/i2c/et8ek8/et8ek8_driver.c
> > @@ -1496,7 +1496,6 @@ MODULE_DEVICE_TABLE(i2c, et8ek8_id_table);
> > static const struct dev_pm_ops et8ek8_pm_ops = {
> > SET_SYSTEM_SLEEP_PM_OPS(et8ek8_suspend, et8ek8_resume)
> > };
> > -MODULE_DEVICE_TABLE(of, et8ek8_of_table);
> >
> > static struct i2c_driver et8ek8_i2c_driver = {
> > .driver = {
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2017-08-07 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 9:01 [PATCH] Revert "[media] et8ek8: Export OF device ID as module aliases" Arnd Bergmann
2017-06-08 12:49 ` Sakari Ailus
2017-06-08 16:40 ` Pavel Machek
2017-08-06 23:29 ` Stefan Agner
2017-08-07 11:09 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170807110907.GA28655@amd \
--to=pavel@ucw.cz \
--cc=arnd@arndb.de \
--cc=fengguang.wu@intel.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=javier@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).