From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Daniel Scheller <d.scheller.oss@gmail.com>, rjkm@metzlerbros.de
Cc: linux-media@vger.kernel.org, mchehab@kernel.org, jasmin@anw.at
Subject: Re: [PATCH] [media] ddbridge: add IOCTLs
Date: Sun, 20 Aug 2017 08:53:56 -0300 [thread overview]
Message-ID: <20170820085356.0aa87e66@vento.lan> (raw)
In-Reply-To: <20170820110855.7127-1-d.scheller.oss@gmail.com>
Em Sun, 20 Aug 2017 13:08:55 +0200
Daniel Scheller <d.scheller.oss@gmail.com> escreveu:
> From: Daniel Scheller <d.scheller@gmx.net>
>
> This patch adds back the IOCTL API/functionality which is present in the
> upstream dddvb driver package. In comparison, the IOCTL handler has been
> factored to a separate object (and with that, some functionality from
> -core has been moved there aswell), the IOCTLs are defined in an include
> in the uAPI, and ioctl-number.txt is updated to document that there are
> IOCTLs present in this driver.
>
> Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
> ---
> This patch depends on the ddbridge-0.9.29 bump, see [1]. The
> functionality was part of the driver before.
>
> [1] http://www.spinics.net/lists/linux-media/msg119911.html
>
> Documentation/ioctl/ioctl-number.txt | 1 +
> MAINTAINERS | 1 +
> drivers/media/pci/ddbridge/Makefile | 2 +-
> drivers/media/pci/ddbridge/ddbridge-core.c | 111 +--------
> drivers/media/pci/ddbridge/ddbridge-ioctl.c | 334 ++++++++++++++++++++++++++++
> drivers/media/pci/ddbridge/ddbridge-ioctl.h | 32 +++
> include/uapi/linux/ddbridge-ioctl.h | 110 +++++++++
> 7 files changed, 481 insertions(+), 110 deletions(-)
> create mode 100644 drivers/media/pci/ddbridge/ddbridge-ioctl.c
> create mode 100644 drivers/media/pci/ddbridge/ddbridge-ioctl.h
> create mode 100644 include/uapi/linux/ddbridge-ioctl.h
>
> diff --git a/Documentation/ioctl/ioctl-number.txt b/Documentation/ioctl/ioctl-number.txt
> index 3e3fdae5f3ed..d78d1cd092d2 100644
> --- a/Documentation/ioctl/ioctl-number.txt
> +++ b/Documentation/ioctl/ioctl-number.txt
> @@ -215,6 +215,7 @@ Code Seq#(hex) Include File Comments
> 'c' A0-AF arch/x86/include/asm/msr.h conflict!
> 'd' 00-FF linux/char/drm/drm.h conflict!
> 'd' 02-40 pcmcia/ds.h conflict!
> +'d' 00-0B linux/ddbridge-ioctl.h conflict!
That's where the problem with this patch starts: we don't add conflicts
here :-)
We need more discussions with regards to the features added by this
patchset.
Anyway, I applied today the ddbridge patches we had. I solved a few
conflicts while merging some things, so I'd appreciate if you could
check if everything is ok. If not, please send patches :-)
Regards,
Mauro
next prev parent reply other threads:[~2017-08-20 11:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-20 11:08 [PATCH] [media] ddbridge: add IOCTLs Daniel Scheller
2017-08-20 11:53 ` Mauro Carvalho Chehab [this message]
2017-08-20 12:11 ` Daniel Scheller
2017-08-20 12:14 ` Daniel Scheller
2017-08-22 14:05 ` Ralph Metzler
2017-08-22 15:21 ` Daniel Scheller
2017-11-26 17:19 ` Daniel Scheller
2017-12-14 11:48 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170820085356.0aa87e66@vento.lan \
--to=mchehab@s-opensource.com \
--cc=d.scheller.oss@gmail.com \
--cc=jasmin@anw.at \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rjkm@metzlerbros.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).