* Duplicated debug message in drivers/media/rc/rc-main.c
@ 2017-09-12 12:39 Mason
2017-09-12 15:30 ` Sean Young
0 siblings, 1 reply; 3+ messages in thread
From: Mason @ 2017-09-12 12:39 UTC (permalink / raw)
To: Sean Young, Mauro Carvalho Chehab; +Cc: linux-media
Hello,
I enabled all debug messages, and I see:
[ 1.931214] Allocated space for 1 keycode entries (8 bytes)
[ 1.936822] Allocated space for 1 keycode entries (8 bytes)
One comes from ir_create_table()
The other from ir_setkeytable()
ir_setkeytable() calls ir_create_table()
It looks like one of the two debug messages should be deleted?
Regards.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Duplicated debug message in drivers/media/rc/rc-main.c
2017-09-12 12:39 Duplicated debug message in drivers/media/rc/rc-main.c Mason
@ 2017-09-12 15:30 ` Sean Young
2017-09-18 14:31 ` [PATCH] media: rc: Delete duplicate debug message Marc Gonzalez
0 siblings, 1 reply; 3+ messages in thread
From: Sean Young @ 2017-09-12 15:30 UTC (permalink / raw)
To: Mason; +Cc: Mauro Carvalho Chehab, linux-media
Hi Mason,
On Tue, Sep 12, 2017 at 02:39:14PM +0200, Mason wrote:
> Hello,
>
> I enabled all debug messages, and I see:
>
> [ 1.931214] Allocated space for 1 keycode entries (8 bytes)
> [ 1.936822] Allocated space for 1 keycode entries (8 bytes)
>
> One comes from ir_create_table()
> The other from ir_setkeytable()
>
> ir_setkeytable() calls ir_create_table()
>
> It looks like one of the two debug messages should be deleted?
Yes, you're right. Patches are welcome :)
Thanks
Sean
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] media: rc: Delete duplicate debug message
2017-09-12 15:30 ` Sean Young
@ 2017-09-18 14:31 ` Marc Gonzalez
0 siblings, 0 replies; 3+ messages in thread
From: Marc Gonzalez @ 2017-09-18 14:31 UTC (permalink / raw)
To: Sean Young, Mauro Carvalho Chehab; +Cc: linux-media, Mason
ir_setkeytable() and ir_create_table() print the same debug message.
Delete the one in ir_setkeytable()
Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
---
drivers/media/rc/rc-main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index 981cccd6b988..a881d7c161e1 100644
--- a/drivers/media/rc/rc-main.c
+++ b/drivers/media/rc/rc-main.c
@@ -439,9 +439,6 @@ static int ir_setkeytable(struct rc_dev *dev,
if (rc)
return rc;
- IR_dprintk(1, "Allocated space for %u keycode entries (%u bytes)\n",
- rc_map->size, rc_map->alloc);
-
for (i = 0; i < from->size; i++) {
index = ir_establish_scancode(dev, rc_map,
from->scan[i].scancode, false);
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-18 14:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-12 12:39 Duplicated debug message in drivers/media/rc/rc-main.c Mason
2017-09-12 15:30 ` Sean Young
2017-09-18 14:31 ` [PATCH] media: rc: Delete duplicate debug message Marc Gonzalez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).