From: Dan Carpenter <dan.carpenter@oracle.com>
To: Allen Pais <allen.lkml@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, mchehab@kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v3] drivers/staging:[media]atomisp:use ARRAY_SIZE() instead of open coding.
Date: Wed, 13 Sep 2017 12:10:00 +0300 [thread overview]
Message-ID: <20170913091000.3dtzrx3rr4g5rql3@mwanda> (raw)
In-Reply-To: <1505293073-27622-1-git-send-email-allen.lkml@gmail.com>
On Wed, Sep 13, 2017 at 02:27:53PM +0530, Allen Pais wrote:
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
Sorry, the patch is right, but the commit is still totally messed up.
bad: [PATCH v3] drivers/staging:[media]atomisp:use ARRAY_SIZE() instead of open coding.
good: [PATCH v4] [media] atomisp: use ARRAY_SIZE() instead of open coding.
Please, copy the "[media] atomisp: " prefix exactly as I wrote it. Then
the commit message can say something like:
The array_length() macro just duplicates ARRAY_SIZE() so we can delete
it.
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
> ---
^^^
Then under the --- line put:
v4: Update the commit message.
regards,
dan carpenter
next prev parent reply other threads:[~2017-09-13 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 8:57 [PATCH v3] drivers/staging:[media]atomisp:use ARRAY_SIZE() instead of open coding Allen Pais
2017-09-13 9:10 ` Dan Carpenter [this message]
2017-09-13 9:17 ` Allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913091000.3dtzrx3rr4g5rql3@mwanda \
--to=dan.carpenter@oracle.com \
--cc=allen.lkml@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox