Re: [PATCH v3 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

[Maxime Ripard <maxime.ripard@free-electrons.com>]

[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]

On Tue, Sep 12, 2017 at 02:13:12PM -0500, Benoit Parrot wrote:
> > > +	/*
> > > +	 * Create a static mapping between the CSI virtual channels
> > > +	 * and the output stream.
> > > +	 *
> > > +	 * This should be enhanced, but v4l2 lacks the support for
> > > +	 * changing that mapping dynamically.
> > > +	 *
> > > +	 * We also cannot enable and disable independant streams here,
> > > +	 * hence the reference counting.
> > > +	 */
> > > +	for (i = 0; i < csi2rx->max_streams; i++) {
> > > +		clk_prepare_enable(csi2rx->pixel_clk[i]);
> > > +
> > > +		writel(CSI2RX_STREAM_CFG_FIFO_MODE_LARGE_BUF,
> > > +		       csi2rx->base + CSI2RX_STREAM_CFG_REG(i));
> > > +
> > > +		writel(CSI2RX_STREAM_DATA_CFG_EN_VC_SELECT |
> > > +		       CSI2RX_STREAM_DATA_CFG_VC_SELECT(i),
> > > +		       csi2rx->base + CSI2RX_STREAM_DATA_CFG_REG(i));
> 
> I see here that we are setting the data_type to 0 (as we are not
> setting it) so effectively capturing everything on the channel(s).
> Will we be adding a method to select/filter specific data type?  For
> instance if we only want to grab YUV data in one stream and only
> RGB24 in another. Of course that would not be possible here as is...

Ah, right, I forgot about that. I've actually started that discussion
on another thread for a transceiver, without much success though:
https://www.mail-archive.com/linux-media@vger.kernel.org/msg117920.html

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]