From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Shuah Khan <shuah@kernel.org>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Max Kellermann <max.kellermann@gmail.com>,
Colin Ian King <colin.king@canonical.com>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH 2/6] media: dvb_frontend: cleanup ioctl handling logic
Date: Wed, 20 Sep 2017 18:16:23 -0300 [thread overview]
Message-ID: <20170920181623.67816753@recife.lan> (raw)
In-Reply-To: <1446c8bb-4df9-299d-b565-afdbdada85f2@kernel.org>
Em Wed, 20 Sep 2017 14:58:12 -0600
Shuah Khan <shuah@kernel.org> escreveu:
> > + c->state = DTV_UNDEFINED;> + err = dvb_frontend_handle_ioctl(file, cmd, parg);
>
> With this change, c->state value gets changed unconditionally before
> calling the ioctl.
>
> dvb_frontend_ioctl_properties() has logic for c->state == DTV_TUNE.
> Is it safe to set change c->state here? I think it should be set
> only when cmd is != FE_SET_PROPERTY or FE_GET_PROPERTY??
It doesn't mind. c->state is used just for debugging purposes. One of the
patches I made got rid of it.
Thanks,
Mauro
next prev parent reply other threads:[~2017-09-20 21:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 13:42 [PATCH 1/6] media: dvb_frontend: cleanup dvb_frontend_ioctl_properties() Mauro Carvalho Chehab
2017-09-19 13:42 ` [PATCH 2/6] media: dvb_frontend: cleanup ioctl handling logic Mauro Carvalho Chehab
2017-09-20 20:58 ` Shuah Khan
2017-09-20 21:16 ` Mauro Carvalho Chehab [this message]
2017-09-19 13:42 ` [PATCH 3/6] media: dvb_frontend: get rid of proprierty cache's state Mauro Carvalho Chehab
2017-09-20 21:08 ` Shuah Khan
2017-09-19 13:42 ` [PATCH 4/6] media: dvb_frontend.h: fix alignment at the cache properties Mauro Carvalho Chehab
2017-09-19 13:42 ` [PATCH 5/6] media: dvb_frontend: better document the -EPERM condition Mauro Carvalho Chehab
2017-09-20 21:12 ` Shuah Khan
2017-09-19 13:42 ` [PATCH 6/6] media: dvb_frontend: fix return values for FE_SET_PROPERTY Mauro Carvalho Chehab
2017-09-20 20:11 ` [PATCH 1/6] media: dvb_frontend: cleanup dvb_frontend_ioctl_properties() Shuah Khan
2017-09-20 20:27 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920181623.67816753@recife.lan \
--to=mchehab@s-opensource.com \
--cc=colin.king@canonical.com \
--cc=linux-media@vger.kernel.org \
--cc=max.kellermann@gmail.com \
--cc=mchehab@infradead.org \
--cc=shuah@kernel.org \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).