From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: niklas.soderlund@ragnatech.se, maxime.ripard@free-electrons.com,
hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com,
pavel@ucw.cz, sre@kernel.org
Subject: [PATCH v15 06/32] v4l: async: Use more intuitive names for internal functions
Date: Thu, 5 Oct 2017 00:50:25 +0300 [thread overview]
Message-ID: <20171004215051.13385-7-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20171004215051.13385-1-sakari.ailus@linux.intel.com>
Rename internal functions to make the names of the functions better
describe what they do.
Old name New name
v4l2_async_test_notify v4l2_async_match_notify
v4l2_async_belongs v4l2_async_find_match
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/media/v4l2-core/v4l2-async.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
index cde2cf2ab4b0..8b84fea50c2a 100644
--- a/drivers/media/v4l2-core/v4l2-async.c
+++ b/drivers/media/v4l2-core/v4l2-async.c
@@ -60,8 +60,8 @@ static LIST_HEAD(subdev_list);
static LIST_HEAD(notifier_list);
static DEFINE_MUTEX(list_lock);
-static struct v4l2_async_subdev *v4l2_async_belongs(struct v4l2_async_notifier *notifier,
- struct v4l2_subdev *sd)
+static struct v4l2_async_subdev *v4l2_async_find_match(
+ struct v4l2_async_notifier *notifier, struct v4l2_subdev *sd)
{
bool (*match)(struct v4l2_subdev *, struct v4l2_async_subdev *);
struct v4l2_async_subdev *asd;
@@ -95,9 +95,9 @@ static struct v4l2_async_subdev *v4l2_async_belongs(struct v4l2_async_notifier *
return NULL;
}
-static int v4l2_async_test_notify(struct v4l2_async_notifier *notifier,
- struct v4l2_subdev *sd,
- struct v4l2_async_subdev *asd)
+static int v4l2_async_match_notify(struct v4l2_async_notifier *notifier,
+ struct v4l2_subdev *sd,
+ struct v4l2_async_subdev *asd)
{
int ret;
@@ -187,11 +187,11 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev,
list_for_each_entry_safe(sd, tmp, &subdev_list, async_list) {
int ret;
- asd = v4l2_async_belongs(notifier, sd);
+ asd = v4l2_async_find_match(notifier, sd);
if (!asd)
continue;
- ret = v4l2_async_test_notify(notifier, sd, asd);
+ ret = v4l2_async_match_notify(notifier, sd, asd);
if (ret < 0) {
mutex_unlock(&list_lock);
return ret;
@@ -255,13 +255,14 @@ int v4l2_async_register_subdev(struct v4l2_subdev *sd)
INIT_LIST_HEAD(&sd->async_list);
list_for_each_entry(notifier, ¬ifier_list, list) {
- struct v4l2_async_subdev *asd = v4l2_async_belongs(notifier, sd);
+ struct v4l2_async_subdev *asd = v4l2_async_find_match(notifier,
+ sd);
int ret;
if (!asd)
continue;
- ret = v4l2_async_test_notify(notifier, sd, asd);
+ ret = v4l2_async_match_notify(notifier, sd, asd);
if (ret)
goto err_unlock;
--
2.11.0
next prev parent reply other threads:[~2017-10-04 21:50 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 21:50 [PATCH v15 00/32] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 01/32] v4l: async: Remove re-probing support Sakari Ailus
2017-10-08 21:50 ` Sebastian Reichel
2017-10-09 11:22 ` Mauro Carvalho Chehab
2017-10-09 14:06 ` Sakari Ailus
2017-10-09 14:08 ` Hans Verkuil
2017-10-09 14:18 ` Sakari Ailus
2017-10-09 14:20 ` Hans Verkuil
2017-10-09 15:27 ` Mauro Carvalho Chehab
[not found] ` <CGME20171009164457epcas1p3c5e134e4bb5d85498fe8d4f00332f2fc@epcas1p3.samsung.com>
2017-10-09 16:44 ` Sylwester Nawrocki
2017-10-09 19:18 ` Laurent Pinchart
2017-10-10 12:18 ` Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 02/32] v4l: async: Don't set sd->dev NULL in v4l2_async_cleanup Sakari Ailus
2017-10-08 21:50 ` Sebastian Reichel
2017-10-09 11:21 ` Hans Verkuil
2017-10-04 21:50 ` [PATCH v15 03/32] v4l: async: fix unbind error in v4l2_async_notifier_unregister() Sakari Ailus
2017-10-08 21:50 ` Sebastian Reichel
2017-10-09 11:23 ` Hans Verkuil
2017-10-04 21:50 ` [PATCH v15 04/32] v4l: async: Fix notifier complete callback error handling Sakari Ailus
2017-10-09 11:45 ` Hans Verkuil
2017-10-10 12:57 ` Sakari Ailus
2017-10-10 13:18 ` Hans Verkuil
2017-10-10 14:21 ` Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 05/32] v4l: async: Correctly serialise async sub-device unregistration Sakari Ailus
2017-10-08 21:52 ` Sebastian Reichel
2017-10-09 11:45 ` Hans Verkuil
2017-10-04 21:50 ` Sakari Ailus [this message]
2017-10-08 21:53 ` [PATCH v15 06/32] v4l: async: Use more intuitive names for internal functions Sebastian Reichel
2017-10-04 21:50 ` [PATCH v15 07/32] v4l: async: Add V4L2 async documentation to the documentation build Sakari Ailus
2017-10-08 21:54 ` Sebastian Reichel
2017-10-09 11:31 ` Mauro Carvalho Chehab
2017-10-04 21:50 ` [PATCH v15 08/32] v4l: fwnode: Support generic parsing of graph endpoints in a device Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 09/32] omap3isp: Use generic parser for parsing fwnode endpoints Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 10/32] rcar-vin: " Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 11/32] omap3isp: Fix check for our own sub-devices Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 12/32] omap3isp: Print the name of the entity where no source pads could be found Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 13/32] v4l: async: Move async subdev notifier operations to a separate structure Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 14/32] v4l: async: Introduce helpers for calling async ops callbacks Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 15/32] v4l: async: Register sub-devices before calling bound callback Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 16/32] v4l: async: Allow async notifier register call succeed with no subdevs Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 17/32] v4l: async: Prepare for async sub-device notifiers Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 18/32] v4l: async: Allow binding notifiers to sub-devices Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 19/32] v4l: async: Ensure only unique fwnodes are registered to notifiers Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 20/32] dt: bindings: Add a binding for flash LED devices associated to a sensor Sakari Ailus
2017-10-13 13:41 ` Rob Herring
2017-10-04 21:50 ` [PATCH v15 21/32] dt: bindings: Add lens-focus binding for image sensors Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 22/32] v4l: fwnode: Move KernelDoc documentation to the header Sakari Ailus
2017-10-05 12:03 ` [PATCH v15.1 " Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 23/32] v4l: fwnode: Add a helper function for parsing generic references Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 24/32] v4l: fwnode: Add a helper function to obtain device / integer references Sakari Ailus
2017-10-18 13:56 ` [PATCH v15.1 " Sakari Ailus
2017-10-18 15:32 ` Sakari Ailus
2017-10-19 6:52 ` Hans Verkuil
2017-10-20 11:35 ` Sakari Ailus
2017-10-24 20:32 ` [PATCH v15.2 " Sakari Ailus
2017-10-24 20:36 ` Sakari Ailus
2017-10-25 7:28 ` Hans Verkuil
2017-10-04 21:50 ` [PATCH v15 25/32] v4l: fwnode: Add convenience function for parsing common external refs Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 26/32] v4l: fwnode: Add a convenience function for registering sensors Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 27/32] dt: bindings: smiapp: Document lens-focus and flash-leds properties Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 28/32] smiapp: Add support for flash and lens devices Sakari Ailus
2017-10-06 11:21 ` Pavel Machek
2017-10-04 21:50 ` [PATCH v15 29/32] et8ek8: " Sakari Ailus
2017-10-06 11:21 ` Pavel Machek
2017-10-04 21:50 ` [PATCH v15 30/32] ov5670: " Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 31/32] ov13858: " Sakari Ailus
2017-10-04 21:50 ` [PATCH v15 32/32] arm: dts: omap3: N9/N950: Add flash references to the camera Sakari Ailus
2017-10-05 6:11 ` [PATCH v15 00/32] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004215051.13385-7-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).