From: "Tobin C. Harding" <me@tobin.cc>
To: Branislav Radocaj <branislav@radocaj.org>
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org,
hans.verkuil@cisco.com, devel@driverdev.osuosl.org,
nikola.jelic83@gmail.com, ran.algawi@gmail.com,
linux-kernel@vger.kernel.org, jb@abbadie.fr, shilpapri@gmail.com,
aquannie@gmail.com, linux-media@vger.kernel.org
Subject: Re: [PATCH v2] Staging: bcm2048 fix bare use of 'unsigned' in radio-bcm2048.c
Date: Wed, 11 Oct 2017 10:42:50 +1100 [thread overview]
Message-ID: <20171010234250.GC2049@eros> (raw)
In-Reply-To: <20171010132919.18428-1-branislav@radocaj.org>
Hi Branislav,
On Tue, Oct 10, 2017 at 03:29:19PM +0200, Branislav Radocaj wrote:
> This is a patch to the radio-bcm2048.c file that fixes up
> a warning found by the checkpatch.pl tool.
>
> Signed-off-by: Branislav Radocaj <branislav@radocaj.org>
Nice work, a few git log nit picks for you to ensure your future kernel development success.
You can read all this in Documentaton/process/submitting-patches.rst (section 2).
- You can use imperative mood, i.e 'Fix foo by doing bar' instead of 'This patch ...'
- We don't need to mention the file (either in the summary or in the body), people can see this from
the diff.
This is one way of writing the git log message for checkpatch fixes
checkpatch emits WARNING: EXPORT_SYMBOL(foo); should immediately follow
its function/variable.
Move EXPORT_SYMBOL macro call to immediately follow function definition.
Good work, hope this helps.
Tobin
prev parent reply other threads:[~2017-10-10 23:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 13:29 [PATCH v2] Staging: bcm2048 fix bare use of 'unsigned' in radio-bcm2048.c Branislav Radocaj
2017-10-10 23:42 ` Tobin C. Harding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010234250.GC2049@eros \
--to=me@tobin.cc \
--cc=aquannie@gmail.com \
--cc=branislav@radocaj.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=jb@abbadie.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nikola.jelic83@gmail.com \
--cc=ran.algawi@gmail.com \
--cc=shilpapri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).