From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from muru.com ([72.249.23.125]:44206 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752545AbdJMTB0 (ORCPT ); Fri, 13 Oct 2017 15:01:26 -0400 Date: Fri, 13 Oct 2017 12:01:23 -0700 From: Tony Lindgren To: Benoit Parrot Cc: Tero Kristo , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [Patch 5/6] ARM: DRA7: hwmod: Add VPE nodes Message-ID: <20171013190122.GT4394@atomide.com> References: <20171012192719.15193-1-bparrot@ti.com> <20171012192719.15193-6-bparrot@ti.com> <20171013170513.GM4394@atomide.com> <20171013180534.GI25400@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171013180534.GI25400@ti.com> Sender: linux-media-owner@vger.kernel.org List-ID: * Benoit Parrot [171013 11:06]: > Tony Lindgren wrote on Fri [2017-Oct-13 10:05:13 -0700]: > > * Benoit Parrot [171012 12:28]: > > > +static struct omap_hwmod_class_sysconfig dra7xx_vpe_sysc = { > > > + .sysc_offs = 0x0010, > > > + .sysc_flags = (SYSC_HAS_MIDLEMODE | SYSC_HAS_SIDLEMODE), > > > + .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART | > > > + MSTANDBY_FORCE | MSTANDBY_NO | > > > + MSTANDBY_SMART), > > > + .sysc_fields = &omap_hwmod_sysc_type2, > > > +}; > > > > I think checkpatch.pl --strict would complain about unnecessary > > parentheses, might as well check the whole series while at it. > > I actually ran the whole series through "checkpatch.pl --strict" > before posting. And other then the usual MAINTAINER file needing > update warning for the binding patch it no other warning or error. > > Based on the rest of the file I believe the parentheses around those > flags are at least consistent. OK fine thanks for checking. > Now, would the .rev_offs comment also apply here? I don't think it has it, you might want to dump out the value at offset 0 and see if it contains anything. Regards, Tony