* [PATCH v1 14/15] media: adv7180: Remove duplicate checks [not found] <20171031142149.32512-1-andriy.shevchenko@linux.intel.com> @ 2017-10-31 14:21 ` Andy Shevchenko 2017-10-31 14:21 ` [PATCH v1 15/15] media: i2c: adv748x: Remove duplicate NULL check Andy Shevchenko 1 sibling, 0 replies; 3+ messages in thread From: Andy Shevchenko @ 2017-10-31 14:21 UTC (permalink / raw) To: linux-i2c, Wolfram Sang Cc: Andy Shevchenko, Lars-Peter Clausen, Mauro Carvalho Chehab, linux-media Since i2c_unregister_device() became NULL-aware we may remove duplicate checks. Cc: Lars-Peter Clausen <lars@metafoo.de> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: linux-media@vger.kernel.org Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/media/i2c/adv7180.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index 3df28f2f9b38..c7e2ee7fe8a4 100644 --- a/drivers/media/i2c/adv7180.c +++ b/drivers/media/i2c/adv7180.c @@ -1366,11 +1366,9 @@ static int adv7180_probe(struct i2c_client *client, err_free_ctrl: adv7180_exit_controls(state); err_unregister_vpp_client: - if (state->chip_info->flags & ADV7180_FLAG_I2P) - i2c_unregister_device(state->vpp_client); + i2c_unregister_device(state->vpp_client); err_unregister_csi_client: - if (state->chip_info->flags & ADV7180_FLAG_MIPI_CSI2) - i2c_unregister_device(state->csi_client); + i2c_unregister_device(state->csi_client); mutex_destroy(&state->mutex); return ret; } @@ -1388,10 +1386,8 @@ static int adv7180_remove(struct i2c_client *client) media_entity_cleanup(&sd->entity); adv7180_exit_controls(state); - if (state->chip_info->flags & ADV7180_FLAG_I2P) - i2c_unregister_device(state->vpp_client); - if (state->chip_info->flags & ADV7180_FLAG_MIPI_CSI2) - i2c_unregister_device(state->csi_client); + i2c_unregister_device(state->vpp_client); + i2c_unregister_device(state->csi_client); adv7180_set_power_pin(state, false); -- 2.14.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v1 15/15] media: i2c: adv748x: Remove duplicate NULL check [not found] <20171031142149.32512-1-andriy.shevchenko@linux.intel.com> 2017-10-31 14:21 ` [PATCH v1 14/15] media: adv7180: Remove duplicate checks Andy Shevchenko @ 2017-10-31 14:21 ` Andy Shevchenko 2017-11-03 23:41 ` Kieran Bingham 1 sibling, 1 reply; 3+ messages in thread From: Andy Shevchenko @ 2017-10-31 14:21 UTC (permalink / raw) To: linux-i2c, Wolfram Sang Cc: Andy Shevchenko, Kieran Bingham, Mauro Carvalho Chehab, linux-media Since i2c_unregister_device() became NULL-aware we may remove duplicate NULL check. Cc: Kieran Bingham <kieran.bingham@ideasonboard.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: linux-media@vger.kernel.org Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/media/i2c/adv748x/adv748x-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c index 5ee14f2c2747..10c3d469175c 100644 --- a/drivers/media/i2c/adv748x/adv748x-core.c +++ b/drivers/media/i2c/adv748x/adv748x-core.c @@ -225,10 +225,8 @@ static void adv748x_unregister_clients(struct adv748x_state *state) { unsigned int i; - for (i = 1; i < ARRAY_SIZE(state->i2c_clients); ++i) { - if (state->i2c_clients[i]) - i2c_unregister_device(state->i2c_clients[i]); - } + for (i = 1; i < ARRAY_SIZE(state->i2c_clients); ++i) + i2c_unregister_device(state->i2c_clients[i]); } static int adv748x_initialise_clients(struct adv748x_state *state) -- 2.14.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 15/15] media: i2c: adv748x: Remove duplicate NULL check 2017-10-31 14:21 ` [PATCH v1 15/15] media: i2c: adv748x: Remove duplicate NULL check Andy Shevchenko @ 2017-11-03 23:41 ` Kieran Bingham 0 siblings, 0 replies; 3+ messages in thread From: Kieran Bingham @ 2017-11-03 23:41 UTC (permalink / raw) To: Andy Shevchenko, linux-i2c, Wolfram Sang Cc: Mauro Carvalho Chehab, linux-media Hi Andy, Thankyou for the patch. On 31/10/17 14:21, Andy Shevchenko wrote: > Since i2c_unregister_device() became NULL-aware we may remove duplicate > NULL check. > > Cc: Kieran Bingham <kieran.bingham@ideasonboard.com> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: linux-media@vger.kernel.org > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/media/i2c/adv748x/adv748x-core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c > index 5ee14f2c2747..10c3d469175c 100644 > --- a/drivers/media/i2c/adv748x/adv748x-core.c > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > @@ -225,10 +225,8 @@ static void adv748x_unregister_clients(struct adv748x_state *state) > { > unsigned int i; > > - for (i = 1; i < ARRAY_SIZE(state->i2c_clients); ++i) { > - if (state->i2c_clients[i]) > - i2c_unregister_device(state->i2c_clients[i]); > - } > + for (i = 1; i < ARRAY_SIZE(state->i2c_clients); ++i) > + i2c_unregister_device(state->i2c_clients[i]); > } > > static int adv748x_initialise_clients(struct adv748x_state *state) > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-03 23:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20171031142149.32512-1-andriy.shevchenko@linux.intel.com>
2017-10-31 14:21 ` [PATCH v1 14/15] media: adv7180: Remove duplicate checks Andy Shevchenko
2017-10-31 14:21 ` [PATCH v1 15/15] media: i2c: adv748x: Remove duplicate NULL check Andy Shevchenko
2017-11-03 23:41 ` Kieran Bingham
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).