From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from osg.samsung.com ([64.30.133.232]:50557 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932719AbdKPLZO (ORCPT ); Thu, 16 Nov 2017 06:25:14 -0500 Date: Thu, 16 Nov 2017 09:25:09 -0200 From: Mauro Carvalho Chehab To: =?UTF-8?B?UmFmYcOrbCBDYXJyw6k=?= Cc: linux-media@vger.kernel.org Subject: Re: [PATCH 2/2] dvbv5-daemon: 0 is a valid fd Message-ID: <20171116092509.7b521fbe@vento.lan> In-Reply-To: <20171115113336.3756-2-funman@videolan.org> References: <20171115113336.3756-1-funman@videolan.org> <20171115113336.3756-2-funman@videolan.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-media-owner@vger.kernel.org List-ID: Em Wed, 15 Nov 2017 12:33:36 +0100 Rafaël Carré escreveu: > --- > utils/dvb/dvbv5-daemon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/utils/dvb/dvbv5-daemon.c b/utils/dvb/dvbv5-daemon.c > index 58485ac6..711694e0 100644 > --- a/utils/dvb/dvbv5-daemon.c > +++ b/utils/dvb/dvbv5-daemon.c > @@ -570,7 +570,7 @@ void dvb_remote_log(void *priv, int level, const char *fmt, ...) > > va_end(ap); > > - if (fd > 0) > + if (fd >= 0) > send_data(fd, "%i%s%i%s", 0, "log", level, buf); > else > local_log(level, buf); Patch looks OK. Just need a description explaining why we need to consider fd == 0 and a SOB. Thanks, Mauro