Re: [PATCH 2/2] dvbv5-daemon: 0 is a valid fd

[Mauro Carvalho Chehab <mchehab@s-opensource.com>]

Em Thu, 16 Nov 2017 12:36:24 +0100
Rafaël Carré <funman@videolan.org> escreveu:

> On 16/11/2017 12:25, Mauro Carvalho Chehab wrote:
> > Em Wed, 15 Nov 2017 12:33:36 +0100
> > Rafaël Carré <funman@videolan.org> escreveu:
> >   
> >> ---
> >>  utils/dvb/dvbv5-daemon.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/utils/dvb/dvbv5-daemon.c b/utils/dvb/dvbv5-daemon.c
> >> index 58485ac6..711694e0 100644
> >> --- a/utils/dvb/dvbv5-daemon.c
> >> +++ b/utils/dvb/dvbv5-daemon.c
> >> @@ -570,7 +570,7 @@ void dvb_remote_log(void *priv, int level, const char *fmt, ...)
> >>  
> >>  	va_end(ap);
> >>  
> >> -	if (fd > 0)
> >> +	if (fd >= 0)
> >>  		send_data(fd, "%i%s%i%s", 0, "log", level, buf);
> >>  	else
> >>  		local_log(level, buf);  
> 
> Signed-off-by: Rafaël Carré <funman@videolan.org>
> 
> > 
> > Patch looks OK. Just need a description explaining why we
> > need to consider fd == 0 and a SOB.  
> 
> Sorry, I am not used to do sign-off, will try to remember.
> 
> fd == 0 can happen if the application closes stdin/out/err then opens a
> new fd.
> 
> Should I put this in the commit log?

For this one, no need. Next time, the best is to resend, as I usually
use patchwork also to pick the patches. Patchwork won't automatically
pick new patch descriptions.

> 
> > Thanks,
> > Mauro
> >   
> 



Thanks,
Mauro