From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:47820 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753366AbdK2JPD (ORCPT ); Wed, 29 Nov 2017 04:15:03 -0500 Date: Wed, 29 Nov 2017 10:15:06 +0100 From: Greg KH To: Sakari Ailus Cc: Jeremy Sowden , linux-media@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH 2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage. Message-ID: <20171129091506.GB4414@kroah.com> References: <20171127113054.27657-1-jeremy@azazel.net> <20171127113054.27657-3-jeremy@azazel.net> <20171127122125.GB8561@kroah.com> <20171129090817.3u7bfxa3dapue44t@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171129090817.3u7bfxa3dapue44t@valkosipuli.retiisi.org.uk> Sender: linux-media-owner@vger.kernel.org List-ID: On Wed, Nov 29, 2017 at 11:08:17AM +0200, Sakari Ailus wrote: > Hi Greg, > > On Mon, Nov 27, 2017 at 01:21:25PM +0100, Greg KH wrote: > > On Mon, Nov 27, 2017 at 11:30:53AM +0000, Jeremy Sowden wrote: > > > Signed-off-by: Jeremy Sowden > > > --- > > > .../isp/kernels/eed1_8/ia_css_eed1_8.host.c | 24 +++++++++++----------- > > > 1 file changed, 12 insertions(+), 12 deletions(-) > > > > I can never take patches without any changelog text, and so no one > > should write them that way :) > > I've been applying the atomisp patches to my tree for some time now, > further on passing them to Mauro to be merged via the media tree. To avoid > conflicts, I suggest to avoid merging them via the staging tree. I'm not touching any of these patches, just commenting that patches without changelogs should not be written :) thanks, greg k-h