From: Greg KH <gregkh@linuxfoundation.org>
To: Yisheng Xie <xieyisheng1@huawei.com>
Cc: linux-kernel@vger.kernel.org, ysxie@foxmail.com,
ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
boris.brezillon@free-electrons.com, richard@nod.at,
marek.vasut@gmail.com, cyrille.pitchen@wedev4u.fr,
linux-mtd@lists.infradead.org, alsa-devel@alsa-project.org,
wim@iguana.be, linux@roeck-us.net,
linux-watchdog@vger.kernel.org, b.zolnierkie@samsung.com,
linux-fbdev@vger.kernel.org, linus.walleij@linaro.org,
linux-gpio@vger.kernel.org, ralf@linux-mips.org,
linux-mips@linux-mips.org, lgirdwood@gmail.com,
broonie@kernel.org, tglx@linutronix.de, jason@lakedaemon.net,
marc.zyngier@arm.com, arnd@arndb.de,
andriy.shevchenko@linux.intel.com,
industrypack-devel@lists.sourceforge.net, wg@grandegger.com,
mkl@pengutronix.de, linux-can@vger.kernel.org,
mchehab@kernel.org, linux-media@vger.kernel.org,
a.zummo@towertech.it, alexandre.belloni@free-electrons.com,
linux-rtc@vger.kernel.org, daniel.vetter@intel.com,
jani.nikula@linux.intel.com, seanpaul@chromium.org,
airlied@linux.ie, dri-devel@lists.freedesktop.org,
kvalo@codeaurora.org, linux-wireless@vger.kernel.org,
linux-spi@vger.kernel.org, tj@kernel.org,
linux-ide@vger.kernel.org, bhelgaas@google.com,
linux-pci@vger.kernel.org, devel@driverdev.osuosl.org,
dvhart@infradead.org, andy@infradead.org,
platform-driver-x86@vger.kernel.org,
jakub.kicinski@netronome.com, davem@davemloft.net,
nios2-dev@lists.rocketboards.org, netdev@vger.kernel.org,
vinod.koul@intel.com, dan.j.williams@intel.com,
dmaengine@vger.kernel.org, jslaby@suse.com
Subject: Re: [PATCH v3 00/27] kill devm_ioremap_nocache
Date: Sat, 23 Dec 2017 14:48:31 +0100 [thread overview]
Message-ID: <20171223134831.GB10103@kroah.com> (raw)
In-Reply-To: <1514026525-32538-1-git-send-email-xieyisheng1@huawei.com>
On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote:
> Hi all,
>
> When I tried to use devm_ioremap function and review related code, I found
> devm_ioremap and devm_ioremap_nocache is almost the same with each other,
> except one use ioremap while the other use ioremap_nocache.
For all arches? Really? Look at MIPS, and x86, they have different
functions.
> While ioremap's
> default function is ioremap_nocache, so devm_ioremap_nocache also have the
> same function with devm_ioremap, which can just be killed to reduce the size
> of devres.o(from 20304 bytes to 18992 bytes in my compile environment).
>
> I have posted two versions, which use macro instead of function for
> devm_ioremap_nocache[1] or devm_ioremap[2]. And Greg suggest me to kill
> devm_ioremap_nocache for no need to keep a macro around for the duplicate
> thing. So here comes v3 and please help to review.
I don't think this can be done, what am I missing? These functions are
not identical, sorry for missing that before.
thanks,
greg k-h
next prev parent reply other threads:[~2017-12-23 13:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-23 10:55 [PATCH v3 00/27] kill devm_ioremap_nocache Yisheng Xie
2017-12-23 13:48 ` Greg KH [this message]
2017-12-23 15:57 ` Guenter Roeck
2017-12-24 8:55 ` christophe leroy
2017-12-25 1:09 ` Yisheng Xie
2018-01-03 6:42 ` Yisheng Xie
2017-12-24 9:05 ` christophe leroy
2017-12-25 1:34 ` Yisheng Xie
2018-01-04 8:05 ` Christophe LEROY
2018-01-12 9:12 ` Yisheng Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171223134831.GB10103@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=a.zummo@towertech.it \
--cc=airlied@linux.ie \
--cc=alexandre.belloni@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=bhelgaas@google.com \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dan.j.williams@intel.com \
--cc=daniel.vetter@intel.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=dvhart@infradead.org \
--cc=industrypack-devel@lists.sourceforge.net \
--cc=jakub.kicinski@netronome.com \
--cc=jani.nikula@linux.intel.com \
--cc=jason@lakedaemon.net \
--cc=jslaby@suse.com \
--cc=kvalo@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marc.zyngier@arm.com \
--cc=marek.vasut@gmail.com \
--cc=mchehab@kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=nios2-dev@lists.rocketboards.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=richard@nod.at \
--cc=seanpaul@chromium.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vinod.koul@intel.com \
--cc=wg@grandegger.com \
--cc=wim@iguana.be \
--cc=xieyisheng1@huawei.com \
--cc=ysxie@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox