* [bug report] V4L/DVB(7872): mxl5005s: checkpatch.pl compliance
@ 2018-01-23 10:50 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2018-01-23 10:50 UTC (permalink / raw)
To: stoth; +Cc: linux-media
Hello Steven Toth,
The patch d211017b9544: "V4L/DVB(7872): mxl5005s: checkpatch.pl
compliance" from May 1, 2008, leads to the following static checker
warning:
drivers/media/tuners/mxl5005s.c:1817 MXL_BlockInit()
warn: both sides of ternary the same: '1'
drivers/media/tuners/mxl5005s.c
1812 }
1813
1814 /* Charge Pump Control Dig Ana */
1815 status += MXL_ControlWrite(fe, RFSYN_CHP_GAIN, state->Mode ? 5 : 8);
1816 status += MXL_ControlWrite(fe,
1817 RFSYN_EN_CHP_HIGAIN, state->Mode ? 1 : 1);
^^^^^^^^^^^^^^^^^^^
1818 status += MXL_ControlWrite(fe, EN_CHP_LIN_B, state->Mode ? 0 : 0);
^^^^^^^^^^^^^^^^^^^
What do these mean? What are they supposed to do?
1819
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-01-23 10:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-23 10:50 [bug report] V4L/DVB(7872): mxl5005s: checkpatch.pl compliance Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).