From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org,
Daniel Mentz <danielmentz@google.com>,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH 09/12] v4l2-compat-ioctl32.c: copy clip list in put_v4l2_window32
Date: Mon, 29 Jan 2018 12:13:14 -0200 [thread overview]
Message-ID: <20180129121302.68ec074a@vela.lan> (raw)
In-Reply-To: <20180129094742.x7rofwpgr4yke37h@valkosipuli.retiisi.org.uk>
Em Mon, 29 Jan 2018 11:47:42 +0200
Sakari Ailus <sakari.ailus@iki.fi> escreveu:
> > + compat_caddr_t p;
> > +
> > if (copy_to_user(&up->w, &kp->w, sizeof(kp->w)) ||
> > put_user(kp->field, &up->field) ||
> > put_user(kp->chromakey, &up->chromakey) ||
> > put_user(kp->clipcount, &up->clipcount) ||
> > put_user(kp->global_alpha, &up->global_alpha))
> > return -EFAULT;
>
> One more newline here?
Why? A new line here would be weird.
Cheers,
Mauro
next prev parent reply other threads:[~2018-01-29 14:13 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 12:43 [PATCH 00/12] v4l2-compat-ioctl32.c: remove set_fs(KERNEL_DS) Hans Verkuil
2018-01-26 12:43 ` [PATCH 01/12] vivid: fix module load error when enabling fb and no_error_inj=1 Hans Verkuil
2018-01-26 14:43 ` Sakari Ailus
2018-01-26 12:43 ` [PATCH 02/12] v4l2-ioctl.c: use check_fmt for enum/g/s/try_fmt Hans Verkuil
2018-01-26 14:41 ` Sakari Ailus
2018-01-29 10:09 ` Hans Verkuil
2018-01-29 20:57 ` Sakari Ailus
2018-01-30 8:44 ` Hans Verkuil
2018-01-30 11:14 ` Sakari Ailus
2018-01-26 12:43 ` [PATCH 03/12] v4l2-compat-ioctl32.c: add missing VIDIOC_PREPARE_BUF Hans Verkuil
2018-01-26 14:43 ` Sakari Ailus
2018-01-26 12:43 ` [PATCH 04/12] v4l2-compat-ioctl32.c: fix the indentation Hans Verkuil
2018-01-26 14:57 ` Sakari Ailus
2018-01-26 12:43 ` [PATCH 05/12] v4l2-compat-ioctl32.c: move 'helper' functions to __get/put_v4l2_format32 Hans Verkuil
2018-01-26 15:20 ` Sakari Ailus
2018-01-26 12:43 ` [PATCH 06/12] v4l2-compat-ioctl32.c: avoid sizeof(type) Hans Verkuil
2018-01-26 15:35 ` Sakari Ailus
2018-01-26 12:43 ` [PATCH 07/12] v4l2-compat-ioctl32.c: copy m.userptr in put_v4l2_plane32 Hans Verkuil
2018-01-26 16:15 ` Sakari Ailus
2018-01-26 12:43 ` [PATCH 08/12] v4l2-compat-ioctl32.c: fix ctrl_is_pointer Hans Verkuil
2018-01-27 23:18 ` Sakari Ailus
2018-01-29 14:11 ` Mauro Carvalho Chehab
2018-01-26 12:43 ` [PATCH 09/12] v4l2-compat-ioctl32.c: copy clip list in put_v4l2_window32 Hans Verkuil
2018-01-29 9:47 ` Sakari Ailus
2018-01-29 14:13 ` Mauro Carvalho Chehab [this message]
2018-01-29 21:00 ` Sakari Ailus
2018-01-26 12:43 ` [PATCH 10/12] v4l2-compat-ioctl32.c: drop pr_info for unknown buffer type Hans Verkuil
2018-01-29 9:48 ` Sakari Ailus
2018-01-26 12:43 ` [PATCH 11/12] v4l2-compat-ioctl32.c: don't copy back the result for certain errors Hans Verkuil
2018-01-29 9:56 ` Sakari Ailus
2018-01-29 10:02 ` Hans Verkuil
2018-01-29 21:01 ` Sakari Ailus
2018-01-26 12:43 ` [PATCH 12/12] v4l2-compat-ioctl32.c: refactor, fix security bug in compat ioctl32 Hans Verkuil
2018-01-29 15:14 ` Mauro Carvalho Chehab
2018-01-29 17:06 ` Sakari Ailus
2018-01-29 17:41 ` Hans Verkuil
2018-01-29 21:14 ` Sakari Ailus
2018-01-30 9:37 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129121302.68ec074a@vela.lan \
--to=mchehab@s-opensource.com \
--cc=danielmentz@google.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).