From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wr0-f194.google.com ([209.85.128.194]:33046 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256AbeA2NaV (ORCPT ); Mon, 29 Jan 2018 08:30:21 -0500 Received: by mail-wr0-f194.google.com with SMTP id s5so7225995wra.0 for ; Mon, 29 Jan 2018 05:30:20 -0800 (PST) Date: Mon, 29 Jan 2018 14:30:14 +0100 From: LABBE Corentin To: Andy Shevchenko Cc: Greg Kroah-Hartman , Mauro Carvalho Chehab , devel@driverdev.osuosl.org, Linux Kernel Mailing List , Linux Media Mailing List Subject: Re: [PATCH] staging: media: atomisp2: remove unused headers Message-ID: <20180129133014.GB32503@Red> References: <1517231511-2295-1-git-send-email-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-media-owner@vger.kernel.org List-ID: On Mon, Jan 29, 2018 at 03:22:33PM +0200, Andy Shevchenko wrote: > On Mon, Jan 29, 2018 at 3:11 PM, Corentin Labbe wrote: > > All thoses headers are not used by any source files. > > Lets just remove them. > > How did you test this? > > P.S. I like the patch, but since driver in a state of coma vigil, I'm > afraid you may do something which shouldn't be done for working > driver. > For testing I have: - successfully compiling the driver - for each file, grepping its name in tree to be sure that no one uses it.