Linux Media Controller development
 help / color / mirror / Atom feed
From: jacopo mondi <jacopo@jmondi.org>
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	Bhumika Goyal <bhumirks@gmail.com>
Subject: Re: [PATCH] media: ov772x: constify ov772x_frame_intervals
Date: Tue, 6 Mar 2018 17:05:26 +0100	[thread overview]
Message-ID: <20180306160526.GC19648@w540> (raw)
In-Reply-To: <7b69f2cb91319abdacf37be501db2eae45112a09.1520350517.git.mchehab@s-opensource.com>

Hi Mauro,

On Tue, Mar 06, 2018 at 10:35:22AM -0500, Mauro Carvalho Chehab wrote:
> The values on this array never changes. Make it const.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

Acked-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Since I'm sure there will be more cleanup/fixes on tw9910 and ov772x,
could you please take into account my series:
[PATCH v2 00/11] media: ov772x/tw9910 cleanup
before any additional change to these 2 drivers?

Thanks
   j
> ---
>  drivers/media/i2c/ov772x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
> index 16665af0c712..321105bb3161 100644
> --- a/drivers/media/i2c/ov772x.c
> +++ b/drivers/media/i2c/ov772x.c
> @@ -531,7 +531,7 @@ static const struct ov772x_win_size ov772x_win_sizes[] = {
>  /*
>   * frame rate settings lists
>   */
> -static unsigned int ov772x_frame_intervals[] = { 5, 10, 15, 20, 30, 60 };
> +static const unsigned int ov772x_frame_intervals[] = { 5, 10, 15, 20, 30, 60 };
>
>  /*
>   * general function
> --
> 2.14.3
>

  reply	other threads:[~2018-03-06 16:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 15:35 [PATCH] media: ov772x: constify ov772x_frame_intervals Mauro Carvalho Chehab
2018-03-06 16:05 ` jacopo mondi [this message]
2018-03-06 16:34   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180306160526.GC19648@w540 \
    --to=jacopo@jmondi.org \
    --cc=bhumirks@gmail.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=hans.verkuil@cisco.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mchehab@s-opensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox