* [PATCH] media: ov772x: constify ov772x_frame_intervals
@ 2018-03-06 15:35 Mauro Carvalho Chehab
2018-03-06 16:05 ` jacopo mondi
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2018-03-06 15:35 UTC (permalink / raw)
Cc: Mauro Carvalho Chehab, Linux Media Mailing List,
Mauro Carvalho Chehab, Jacopo Mondi, Laurent Pinchart,
Hans Verkuil, Guennadi Liakhovetski, Bhumika Goyal
The values on this array never changes. Make it const.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
drivers/media/i2c/ov772x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
index 16665af0c712..321105bb3161 100644
--- a/drivers/media/i2c/ov772x.c
+++ b/drivers/media/i2c/ov772x.c
@@ -531,7 +531,7 @@ static const struct ov772x_win_size ov772x_win_sizes[] = {
/*
* frame rate settings lists
*/
-static unsigned int ov772x_frame_intervals[] = { 5, 10, 15, 20, 30, 60 };
+static const unsigned int ov772x_frame_intervals[] = { 5, 10, 15, 20, 30, 60 };
/*
* general function
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] media: ov772x: constify ov772x_frame_intervals
2018-03-06 15:35 [PATCH] media: ov772x: constify ov772x_frame_intervals Mauro Carvalho Chehab
@ 2018-03-06 16:05 ` jacopo mondi
2018-03-06 16:34 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 3+ messages in thread
From: jacopo mondi @ 2018-03-06 16:05 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Media Mailing List, Mauro Carvalho Chehab, Laurent Pinchart,
Hans Verkuil, Guennadi Liakhovetski, Bhumika Goyal
Hi Mauro,
On Tue, Mar 06, 2018 at 10:35:22AM -0500, Mauro Carvalho Chehab wrote:
> The values on this array never changes. Make it const.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Acked-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Since I'm sure there will be more cleanup/fixes on tw9910 and ov772x,
could you please take into account my series:
[PATCH v2 00/11] media: ov772x/tw9910 cleanup
before any additional change to these 2 drivers?
Thanks
j
> ---
> drivers/media/i2c/ov772x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
> index 16665af0c712..321105bb3161 100644
> --- a/drivers/media/i2c/ov772x.c
> +++ b/drivers/media/i2c/ov772x.c
> @@ -531,7 +531,7 @@ static const struct ov772x_win_size ov772x_win_sizes[] = {
> /*
> * frame rate settings lists
> */
> -static unsigned int ov772x_frame_intervals[] = { 5, 10, 15, 20, 30, 60 };
> +static const unsigned int ov772x_frame_intervals[] = { 5, 10, 15, 20, 30, 60 };
>
> /*
> * general function
> --
> 2.14.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: ov772x: constify ov772x_frame_intervals
2018-03-06 16:05 ` jacopo mondi
@ 2018-03-06 16:34 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2018-03-06 16:34 UTC (permalink / raw)
To: jacopo mondi
Cc: Linux Media Mailing List, Mauro Carvalho Chehab, Laurent Pinchart,
Hans Verkuil, Guennadi Liakhovetski, Bhumika Goyal
Em Tue, 6 Mar 2018 17:05:26 +0100
jacopo mondi <jacopo@jmondi.org> escreveu:
> Hi Mauro,
>
> On Tue, Mar 06, 2018 at 10:35:22AM -0500, Mauro Carvalho Chehab wrote:
> > The values on this array never changes. Make it const.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
>
> Acked-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
>
> Since I'm sure there will be more cleanup/fixes on tw9910 and ov772x,
> could you please take into account my series:
> [PATCH v2 00/11] media: ov772x/tw9910 cleanup
> before any additional change to these 2 drivers?
That is the next on my patch queue :-)
Reviewing them right now.
Regards,
Mauro
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-06 16:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-06 15:35 [PATCH] media: ov772x: constify ov772x_frame_intervals Mauro Carvalho Chehab
2018-03-06 16:05 ` jacopo mondi
2018-03-06 16:34 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox