From: Nick French <naf@ou.edu>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
Andy Lutomirski <luto@kernel.org>,
"hans.verkuil@cisco.com" <hans.verkuil@cisco.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: ivtv: use arch_phys_wc_add() and require PAT disabled
Date: Sun, 11 Mar 2018 17:08:24 -0500 [thread overview]
Message-ID: <20180311220823.GA4074@tivo.lan> (raw)
In-Reply-To: <38CB7D59-7F11-4BC3-B73C-C2F0BF16EFF8@amacapital.net>
On Sun, Mar 11, 2018 at 01:19:03PM -0700, Andy Lutomirski wrote:
> From memory, I see two potentially reasonable real fixes. One is to find a way to punch a hole in an ioremap.
> So you’d find the framebuffer, remove it from theproblematic mapping, and then make a new mapping.
> The second is to change the mapping type in place.
For the changing-in-place method, is there already an exported API that exposes change_page_attr_set without first
calling reserve_memtype? I can't seem to find one.
> Or maybe you could just iounmap the whole thing after firmware is loaded and the framebuffer is found and then
> redo the mapping right.
I guess this would require a lock so that the ivtv-driver proper wasn't accessing the decoder's mapped memory
during ivtvfb's iounmap-ioremap window. And a way to notify ivtv-driver proper if things go wrong? I think this method
would be very awkward because its not even memory owned by ivtvfb itself.
- Nick
next prev parent reply other threads:[~2018-03-11 22:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <DM5PR03MB3035EE1AFCEE298AFB15AC46D3C60@DM5PR03MB3035.namprd03.prod.outlook.com>
[not found] ` <20180301171936.GU14069@wotan.suse.de>
[not found] ` <DM5PR03MB303587F12D7E56B951730A76D3D90@DM5PR03MB3035.namprd03.prod.outlook.com>
2018-03-07 19:02 ` ivtv: use arch_phys_wc_add() and require PAT disabled Luis R. Rodriguez
2018-03-08 3:16 ` French, Nicholas A.
2018-03-08 4:06 ` Luis R. Rodriguez
2018-03-08 4:14 ` Luis R. Rodriguez
2018-03-08 5:23 ` French, Nicholas A.
2018-03-10 16:57 ` French, Nicholas A.
2018-03-10 18:20 ` Andy Lutomirski
2018-03-11 19:51 ` Nick French
2018-03-11 20:19 ` Andy Lutomirski
2018-03-11 22:08 ` Nick French [this message]
2018-03-10 19:03 ` Luis R. Rodriguez
2018-03-10 19:05 ` Luis R. Rodriguez
2018-03-11 23:24 ` Ian Armstrong
2018-03-12 4:04 ` Nick French
2018-03-12 19:05 ` Ian Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180311220823.GA4074@tivo.lan \
--to=naf@ou.edu \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox