From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Akihiro TSUKADA <tskd08@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: I2C media binding model
Date: Fri, 16 Mar 2018 13:03:09 -0300 [thread overview]
Message-ID: <20180316130309.1f89476f@vento.lan> (raw)
In-Reply-To: <30147ff6-d0c2-a337-86d2-75fa5454c86c@gmail.com>
Em Fri, 16 Mar 2018 23:50:31 +0900
Akihiro TSUKADA <tskd08@gmail.com> escreveu:
> Hi,
>
> As the new i2c binding helper was introduced,
> I am now re-writing the following patches to use new helper functions.
>
> > 5. Jan,16 2015: [v2,1/2] dvb: tua6034: add a new driver for Infineon tua6034 tuner
> > http://patchwork.linuxtv.org/patch/27927
> > 6. Jan,16 2015: [v2,2/2] dvb-usb-friio: split and merge into dvb-usbv2-gl861
> > http://patchwork.linuxtv.org/patch/27928
Thank you!
> But I noticed that the tua6034 (used in Friio devices) can be supported
> by "tuner-simple" driver.
> Since "tuner-simple" is not an i2c driver,
> I am wondering if
> 1) I should use/modify "tuner-simple" driver without adding new one
> but with one more dvb_attach un-replaced, or,
> 2) I should make a new i2c driver as my previous patch #27927
> but with the duplicated function with tuner-simple.
>
> Re-writing tuner-simple into a new i2c driver does not seem to be
> an option to me, because that would affect lots of dvb/v4l drivers,
> and I cannot test them.
If the driver is pure DVB, then maybe the best would be to add support
for it at:
./drivers/media/dvb-frontends/dvb-pll.c
It basically does the same as a "tuner-simple" driver, but without all
the complexity required to handle V4L2 calls.
It should be simple to convert it to also accept the new I2C binding
and use the new I2C binding at the caller drivers.
> In addition, I also intend to re-write "earth-pt1" driver in the future
> by decomposing the current monolithic module into component drivers:
> bridge: earth-pt1 (cut down one)
> demod: tc90522
> TERR-tuner: tda6654 (NEW?)
> SAT-tuner: qm1d1b0004 (NEW)
Sounds nice!
> There exists a "tda665x" tuner driver (in dvb-frontends/),
> but it does not use the new i2c binding helpers either,
> and it seems that it can be supported by "tuner-simple" as well.
> So the similar situation here, though the tda665x driver is
> used only by "mantis" currently.
It it is just a PLL, then it could also be converted to use
dvb-pll.h at the Mantis driver, and we could get rid of the
driver.
Regards,
Mauro
prev parent reply other threads:[~2018-03-16 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 15:25 I2C media binding model Mauro Carvalho Chehab
2018-03-16 14:50 ` Akihiro TSUKADA
2018-03-16 16:03 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316130309.1f89476f@vento.lan \
--to=mchehab@s-opensource.com \
--cc=linux-media@vger.kernel.org \
--cc=tskd08@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox