From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from osg.samsung.com ([64.30.133.232]:63032 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755407AbeCSKra (ORCPT ); Mon, 19 Mar 2018 06:47:30 -0400 Date: Mon, 19 Mar 2018 07:47:23 -0300 From: Mauro Carvalho Chehab To: Pavel Machek Cc: Hans Verkuil , Ivaylo Dimitrov , pali.rohar@gmail.com, sre@kernel.org, Sakari Ailus , Sakari Ailus , linux-media@vger.kernel.org, hans.verkuil@cisco.com Subject: Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline Message-ID: <20180319074715.5b700405@vento.lan> In-Reply-To: <20180319102354.GA12557@amd> References: <20170426132337.GA6482@amd> <20170508222819.GA14833@amd> <20170509110440.GC28248@amd> <20170516124519.GA25650@amd> <76e09f45-8f04-1149-a744-ccb19f36871a@xs4all.nl> <20180316205512.GA6069@amd> <20180319102354.GA12557@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Mon, 19 Mar 2018 11:23:54 +0100 Pavel Machek escreveu: > Hi! > > > I really don't want to add functions for this to libv4l2. That's just a > > quick hack. The real solution is to parse this from a config > > file. But > > No, this is not a quick hack. These are functions that will eventually > be used by the config parser. (Oh and they allow me to use camera on > complex hardware, but...). > > Hmm, I have mentioned that already. See quoted text below. > > > that is a lot more work and it is something that needs to be designed > > properly. > > > > And that requires someone to put in the time and effort... > > Which is what I'm trying to do. But some cooperation from your side is > needed, too. I acknowledged some kind of parser is needed. I can > do that. Are you willing to cooperate? > > But I need your feedback on the parts below. We can bikeshed about the > parser later. > > Do they look acceptable? Did I hook up right functions in acceptable > way? > > If so, yes, I can proceed with parser. > > Best regards, > Pavel Pavel, I appreciate your efforts of adding support for mc-based devices to libv4l. I guess the main poin that Hans is pointing is that we should take extra care in order to avoid adding new symbols to libv4l ABI/API without being sure that they'll be needed in long term, as removing or changing the API is painful for app developers, and keeping it ABI compatible with apps compiled against previous versions of the library is very painful for us. The hole idea is that generic applications shouldn't notice if the device is using a mc-based device or not. Regards, Mauro