From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: "Jasmin J." <jasmin@anw.at>
Cc: Hans Verkuil <hverkuil@xs4all.nl>, LMML <linux-media@vger.kernel.org>
Subject: Re: Smatch and sparse errors
Date: Sat, 14 Apr 2018 06:46:48 -0300 [thread overview]
Message-ID: <20180414064648.0ad264fa@vento.lan> (raw)
In-Reply-To: <fc6e68a3-817b-8caf-ba4f-dd2ed76d2a52@anw.at>
Em Sat, 14 Apr 2018 03:18:20 +0200
"Jasmin J." <jasmin@anw.at> escreveu:
> Hello Mauro/Hans!
>
> > There is already an upstream patch for hidding it:
> The patch from https://patchwork.kernel.org/patch/10334353 will not
> apply at the smatch tree.
>
> Attached is an updated version for smatch.
Then you're probably not using the right version (or Dan applied some
other stuff yesterday).
Yesterday, I added both trees I'm using here at:
https://git.linuxtv.org/mchehab/sparse.git/
https://git.linuxtv.org/mchehab/smatch.git/
My sparse tree has just one extra patch over upstream.
That's needed after a change at max()/min() macros upstream.
At smatch, my tree has 4 extra patches:
https://git.linuxtv.org/mchehab/smatch.git/
They basically do:
1) rise the execution time/memory usage of sparse;
2) mask errors like "missing break", as gcc checks it already;
3) the same patch for sparse is needed on smatch;
4) disable this warning:
drivers/media/platform/sti/bdisp/bdisp-debug.c:594 bdisp_dbg_perf() debug: sval_binop_signed: invalid divide LLONG_MIN/-1
with is produced every time do_div64() & friends are called.
IMHO, all 4 patches are disabling false-positive only warnings,
although the 4th patch might have something useful, if fixed to
properly handle the 64-bit compat macros.
Thanks,
Mauro
next prev parent reply other threads:[~2018-04-14 9:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 15:27 Smatch and sparse errors Mauro Carvalho Chehab
2018-04-14 1:18 ` Jasmin J.
2018-04-14 9:46 ` Mauro Carvalho Chehab [this message]
2018-04-14 10:06 ` Jasmin J.
2018-04-14 10:51 ` Mauro Carvalho Chehab
2018-04-16 12:14 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180414064648.0ad264fa@vento.lan \
--to=mchehab@s-opensource.com \
--cc=hverkuil@xs4all.nl \
--cc=jasmin@anw.at \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox