From: "Daniel Glöckner" <daniel-gl@gmx.net>
To: Devin Heitmueller <dheitmueller@kernellabs.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: cx88 invalid video opcodes when VBI enabled
Date: Wed, 18 Apr 2018 20:29:59 +0200 [thread overview]
Message-ID: <20180418182959.GA19152@minime.bse> (raw)
In-Reply-To: <CAGoCfizXy6j5rgzDghT3Lo3ZKvoUjLt7P3k7qo5wnX+xEE7m-g@mail.gmail.com>
Hi,
On Tue, Apr 17, 2018 at 09:49:22PM -0400, Devin Heitmueller wrote:
> [ 68.750809] cx88[0]: video y / packed - dma channel status dump
> [ 68.750811] cx88[0]: cmds: initial risc: 0x8aa98000
> [ 68.750813] cx88[0]: cmds: cdt base : 0x00180440
> [ 68.750815] cx88[0]: cmds: cdt size : 0x0000000c
> [ 68.750816] cx88[0]: cmds: iq base : 0x00180400
[...]
> [ 68.750887] cx88[0]: vbi - dma channel status dump
[...]
> [ 68.750899] cx88[0]: cmds: iq wr ptr : 0x0000017f
> [ 68.750901] cx88[0]: cmds: iq rd ptr : 0x00000011
> [ 68.750902] cx88[0]: cmds: cdt current : 0x00000638
[...]
> [ 68.750910] cx88[0]: risc0: 0x8aa98000 [ sync sol irq2 23 21 19 cnt0 resync count=0 ]
> [ 68.750913] cx88[0]: risc1: 0x00180440 [ INVALID 20 19 count=1088 ]
> [ 68.750915] cx88[0]: risc2: 0x0000000c [ INVALID count=12 ]
> [ 68.750918] cx88[0]: risc3: 0x00180400 [ INVALID 20 19 count=1024 ]
The VBI instruction queue read pointer points outside the VBI instruction
queue and into the video y/packed CMDS (to 0x180000+0x11*4). The values
next to the iq rd ptr look ok.
We only initialize the iq rd ptr to zero in cx88_sram_channel_setup and
then never touch it again. The hardware takes care of updating it.
Maybe cx88_sram_channel_setup is sometimes called for channel 24 while the
VBI risc engine is still running? One could try adding a WARN_ONCE at the
top of the function to catch that case.
Best regards,
Daniel
next prev parent reply other threads:[~2018-04-18 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-15 17:37 cx88 invalid video opcodes when VBI enabled Devin Heitmueller
2018-04-17 4:53 ` Daniel Glöckner
2018-04-17 13:05 ` Devin Heitmueller
2018-04-18 1:49 ` Devin Heitmueller
2018-04-18 18:29 ` Daniel Glöckner [this message]
2018-04-20 21:54 ` Daniel Glöckner
2018-04-21 17:57 ` Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418182959.GA19152@minime.bse \
--to=daniel-gl@gmx.net \
--cc=dheitmueller@kernellabs.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox