From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wr0-f196.google.com ([209.85.128.196]:34295 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbeDRRHo (ORCPT ); Wed, 18 Apr 2018 13:07:44 -0400 Received: by mail-wr0-f196.google.com with SMTP id d19-v6so6805425wre.1 for ; Wed, 18 Apr 2018 10:07:44 -0700 (PDT) Date: Wed, 18 Apr 2018 19:07:40 +0200 From: Daniel Scheller To: Mauro Carvalho Chehab Cc: Linux Media Mailing List , Mauro Carvalho Chehab , Hans Verkuil , Douglas Fischer , jasmin@anw.at Subject: Re: [PATCH v2 18/19] media: si470x: allow build both USB and I2C at the same time Message-ID: <20180418190740.092c2344@perian.wuest.de> In-Reply-To: <20180406134603.40d8d055@vento.lan> References: <9e596fe9e1fd9d2c27ae9abaeb900b2e0cd49011.1522959716.git.mchehab@s-opensource.com> <201804062347.x9zW4zaa%fengguang.wu@intel.com> <20180406134603.40d8d055@vento.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Am Fri, 6 Apr 2018 13:46:03 -0300 schrieb Mauro Carvalho Chehab : > Em Sat, 7 Apr 2018 00:21:07 +0800 > kbuild test robot escreveu: > > > Hi Mauro, > > > > I love your patch! Yet something to improve: > > [...] > > Fixed patch enclosed. > > Thanks, > Mauro > > [PATCH] media: si470x: allow build both USB and I2C at the same time > > Currently, either USB or I2C is built. Change it to allow > having both enabled at the same time. > > The main reason is that COMPILE_TEST all[yes/mod]builds will > now contain all drivers under drivers/media. > > Signed-off-by: Mauro Carvalho Chehab FWIW, this patch (which seemingly is commit 58757984ca3c73284a45dd53ac66f1414057cd09 in media_tree.git) seems to break media_build in a way that on my systems only 20 drivers and modules are built now, while it should be in the 650+ modules range. Hans' automated daily testbuilds suffer from the same issue, looking at todays daily build logs (Wednesday.tar.bz2). I personally build against Kernel 4.16.2 on Gentoo. This specific commit/patch was found using # git bisect good v4.17-rc1 # git bisect bad media_tree/master And, "git revert 58767984..." makes all drivers being built again by media_build. Not sure if there's something other for which this patch acts as the trigger of if this needs adaption in media_build, though I thought reporting this doesn't hurt. Best regards, Daniel Scheller -- https://github.com/herrnst