public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v3 5/7] drm/i2c: tda9950: add CEC driver
Date: Fri, 20 Apr 2018 17:07:31 +0100	[thread overview]
Message-ID: <20180420160731.GA16141@n2100.armlinux.org.uk> (raw)
In-Reply-To: <bd644882-50b3-3022-de21-1f0b7fe008b7@xs4all.nl>

On Fri, Apr 20, 2018 at 05:48:12PM +0200, Hans Verkuil wrote:
> On 04/20/2018 05:31 PM, Russell King - ARM Linux wrote:
> > Hi Hans,
> > 
> > Any comments?
> 
> I have been traveling and haven't had time to look at this. Next week will
> be busy as well, but I expect to be able to look at it the week after that.

Well, that doesn't work because I won't be reading mail that week,
and I'll probably simply ignore the excessive backlog when I do
start reading mail again.

> I remember from the previous series that I couldn't test it with my BeagleBone
> Black board (the calibration gpio had to switch from in to out but it wasn't allowed
> since it had an associated irq). That's still a problem?
> 
> I didn't see any changes in that area when I did a quick scan.

Correct, and unless you wish me to do the work for you (in which case
you can pay me) nothing is going to change on that front!  Seriously,
please do not expect me to add support for platforms I don't have
access to.  I'm just a volunteer for this, probably the same as you.

I don't think we ended up with an answer for that problem.  I don't
see that dropping the requested interrupt, using the GPIO, and then
re-requesting the interrupt is an option - how do we handle a failure
to re-request the interrupt?  Do we just ignore the error, or let DRM
stop working properly?

In any case, I don't have a working HDMI CEC-compliant setup anymore,
(no TV, just a HDMI monitor now) so I would rather _not_ change the
driver from its known-to-be-working state.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

  reply	other threads:[~2018-04-20 16:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-09 12:15 [PATCH v3 0/7] TDA998x CEC support Russell King - ARM Linux
2018-04-09 12:16 ` [PATCH v3 1/7] drm/i2c: tda998x: move mutex/waitqueue/timer/work init early Russell King
2018-04-09 12:16 ` [PATCH v3 2/7] drm/i2c: tda998x: fix error cleanup paths Russell King
2018-04-09 12:16 ` [PATCH v3 3/7] drm/i2c: tda998x: move CEC device initialisation later Russell King
2018-04-09 12:16 ` [PATCH v3 4/7] drm/i2c: tda998x: always disable and clear interrupts at probe Russell King
2018-04-09 12:16 ` [PATCH v3 5/7] drm/i2c: tda9950: add CEC driver Russell King
2018-04-20 15:31   ` Russell King - ARM Linux
2018-04-20 15:48     ` Hans Verkuil
2018-04-20 16:07       ` Russell King - ARM Linux [this message]
2018-04-24  9:27   ` Hans Verkuil
2018-04-09 12:16 ` [PATCH v3 6/7] drm/i2c: tda998x: add CEC support Russell King
2018-04-24  9:27   ` Hans Verkuil
2018-04-09 12:16 ` [PATCH v3 7/7] dt-bindings: tda998x: add the calibration gpio Russell King
2018-04-24  9:27   ` Hans Verkuil
2018-04-24  9:29 ` [PATCH v3 0/7] TDA998x CEC support Hans Verkuil
2018-04-24  9:42   ` Russell King - ARM Linux
2018-04-24  9:57     ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180420160731.GA16141@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=airlied@linux.ie \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox