From: "Daniel Glöckner" <daniel-gl@gmx.net>
To: Devin Heitmueller <dheitmueller@kernellabs.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: cx88 invalid video opcodes when VBI enabled
Date: Fri, 20 Apr 2018 23:54:32 +0200 [thread overview]
Message-ID: <20180420215432.GA3747@minime.bse> (raw)
In-Reply-To: <20180418182959.GA19152@minime.bse>
Hi,
On Wed, Apr 18, 2018 at 08:29:59PM +0200, Daniel Glöckner wrote:
> The VBI instruction queue read pointer points outside the VBI instruction
> queue and into the video y/packed CMDS (to 0x180000+0x11*4). The values
> next to the iq rd ptr look ok.
>
> We only initialize the iq rd ptr to zero in cx88_sram_channel_setup and
> then never touch it again. The hardware takes care of updating it.
> Maybe cx88_sram_channel_setup is sometimes called for channel 24 while the
> VBI risc engine is still running?
for some reason I feel like buffer_queue in cx88-vbi.c should not be
calling cx8800_start_vbi_dma as it is also called a few lines further
down in start_streaming.
Devin, can you check if it helps to remove that line and if VBI still
works afterwards?
Best regards,
Daniel
next prev parent reply other threads:[~2018-04-20 21:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-15 17:37 cx88 invalid video opcodes when VBI enabled Devin Heitmueller
2018-04-17 4:53 ` Daniel Glöckner
2018-04-17 13:05 ` Devin Heitmueller
2018-04-18 1:49 ` Devin Heitmueller
2018-04-18 18:29 ` Daniel Glöckner
2018-04-20 21:54 ` Daniel Glöckner [this message]
2018-04-21 17:57 ` Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420215432.GA3747@minime.bse \
--to=daniel-gl@gmx.net \
--cc=dheitmueller@kernellabs.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox