From: Daniel Scheller <d.scheller.oss@gmail.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] media: mxl5xx: fix get_algo()'s return type
Date: Tue, 24 Apr 2018 19:21:13 +0200 [thread overview]
Message-ID: <20180424192113.57f38207@lt530> (raw)
In-Reply-To: <20180424131932.6170-1-luc.vanoostenryck@gmail.com>
Am Tue, 24 Apr 2018 15:19:31 +0200
schrieb Luc Van Oostenryck <luc.vanoostenryck@gmail.com>:
> The method dvb_frontend_ops::get_frontend_algo() is defined as
> returning an 'enum dvbfe_algo', but the implementation in this
> driver returns an 'int'.
>
> Fix this by returning 'enum dvbfe_algo' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
> drivers/media/dvb-frontends/mxl5xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/mxl5xx.c b/drivers/media/dvb-frontends/mxl5xx.c
> index 483ee7d61..274d8fca0 100644
> --- a/drivers/media/dvb-frontends/mxl5xx.c
> +++ b/drivers/media/dvb-frontends/mxl5xx.c
> @@ -375,7 +375,7 @@ static void release(struct dvb_frontend *fe)
> kfree(state);
> }
>
> -static int get_algo(struct dvb_frontend *fe)
> +static enum dvbfe_algo get_algo(struct dvb_frontend *fe)
> {
> return DVBFE_ALGO_HW;
> }
Acked-by: Daniel Scheller <d.scheller@gmx.net>
Best regards,
Daniel Scheller
--
https://github.com/herrnst
prev parent reply other threads:[~2018-04-24 17:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 13:19 [PATCH] media: mxl5xx: fix get_algo()'s return type Luc Van Oostenryck
2018-04-24 17:21 ` Daniel Scheller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424192113.57f38207@lt530 \
--to=d.scheller.oss@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox