From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bombadil.infradead.org ([198.137.202.133]:47468 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751687AbeEDS6f (ORCPT ); Fri, 4 May 2018 14:58:35 -0400 Date: Fri, 4 May 2018 15:58:27 -0300 From: Mauro Carvalho Chehab To: Tim Harvey , Takashi Iwai Cc: Mark Brown , Kuninori Morimoto , Mauro Carvalho Chehab , Linux-ALSA , linux-kernel@vger.kernel.org, linux-media Subject: Re: [PATCH v3][RESEND] media: i2c: tda1997: replace codec to component Message-ID: <20180504155827.3a192297@vento.lan> In-Reply-To: References: <87in8ibrql.wl%kuninori.morimoto.gx@renesas.com> <20180423165213.GL19834@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Mon, 23 Apr 2018 13:59:32 -0700 Tim Harvey escreveu: > On Mon, Apr 23, 2018 at 9:52 AM, Mark Brown wrote: > > On Mon, Apr 23, 2018 at 09:44:17AM -0700, Tim Harvey wrote: > > > >> Could you add some detail to the commit explaining why we need to > >> replace codec to component? I don't really know what that means. > >> Please refer to a commit if the ASoC API is changing in some way we > >> need to catch up with. > > > > This is a big transition in the ASoC API which is nearing completion - > > this driver is one of the last users of the CODEC struct, we've (well, > > mainly Morimoto-san) been migrating things away from it to the more > > general purpose component. There's no one commit to point at really as > > the two have coexisted for a while and we won't be able to finally > > remove the CODEC struct until all the drivers have transitioned away. > > Mark, > > Ok - thanks for the explanation! > > Kuninori, > > Sorry this took so long to get to. Tested on a GW5404 > > Tested-by: Tim Harvey > Acked-by: Tim Harvey In order to keep it together with the patches doing the removal of the old API, it is probably better to apply this via ALSA tree: Acked-by: Mauro Carvalho Chehab > > Regards, > > Tim Thanks, Mauro