* [PATCH] [media] dvb-frontends/tda18271c2dd: silence sparse fall through warning
@ 2018-06-24 13:42 Daniel Scheller
2018-07-30 17:16 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Scheller @ 2018-06-24 13:42 UTC (permalink / raw)
To: mchehab, mchehab; +Cc: linux-media
From: Daniel Scheller <d.scheller@gmx.net>
Add a break statement in set_params() for the SYS_DVBT(2) case to silence
this sparse warning:
drivers/media/dvb-frontends/tda18271c2dd.c:1144:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
as reported in Hans' daily media_tree builds.
Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
---
drivers/media/dvb-frontends/tda18271c2dd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/dvb-frontends/tda18271c2dd.c b/drivers/media/dvb-frontends/tda18271c2dd.c
index 2e1d36ae943b..fcffc7b4acf7 100644
--- a/drivers/media/dvb-frontends/tda18271c2dd.c
+++ b/drivers/media/dvb-frontends/tda18271c2dd.c
@@ -1154,6 +1154,7 @@ static int set_params(struct dvb_frontend *fe)
default:
return -EINVAL;
}
+ break;
case SYS_DVBC_ANNEX_A:
case SYS_DVBC_ANNEX_C:
if (bw <= 6000000)
--
2.16.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] [media] dvb-frontends/tda18271c2dd: silence sparse fall through warning
2018-06-24 13:42 [PATCH] [media] dvb-frontends/tda18271c2dd: silence sparse fall through warning Daniel Scheller
@ 2018-07-30 17:16 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2018-07-30 17:16 UTC (permalink / raw)
To: Daniel Scheller; +Cc: mchehab, mchehab, linux-media
Em Sun, 24 Jun 2018 15:42:50 +0200
Daniel Scheller <d.scheller.oss@gmail.com> escreveu:
> From: Daniel Scheller <d.scheller@gmx.net>
>
> Add a break statement in set_params() for the SYS_DVBT(2) case to silence
> this sparse warning:
>
> drivers/media/dvb-frontends/tda18271c2dd.c:1144:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> as reported in Hans' daily media_tree builds.
>
> Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
> ---
> drivers/media/dvb-frontends/tda18271c2dd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/dvb-frontends/tda18271c2dd.c b/drivers/media/dvb-frontends/tda18271c2dd.c
> index 2e1d36ae943b..fcffc7b4acf7 100644
> --- a/drivers/media/dvb-frontends/tda18271c2dd.c
> +++ b/drivers/media/dvb-frontends/tda18271c2dd.c
> @@ -1154,6 +1154,7 @@ static int set_params(struct dvb_frontend *fe)
> default:
> return -EINVAL;
> }
> + break;
This actually seems to be a bug. Did you test this patch with
an actual hardware?
Regards,
Mauro
Thanks,
Mauro
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-30 18:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-24 13:42 [PATCH] [media] dvb-frontends/tda18271c2dd: silence sparse fall through warning Daniel Scheller
2018-07-30 17:16 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox