Linux Media Controller development
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCHv15 01/35] uapi/linux/media.h: add request API
Date: Tue, 3 Jul 2018 07:04:37 -0300	[thread overview]
Message-ID: <20180703070437.6343905b@coco.lan> (raw)
In-Reply-To: <6009b87f-4eae-0ea3-9e72-e5bd4bb85d59@xs4all.nl>

Em Tue, 3 Jul 2018 11:33:13 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:

> On 03/07/18 11:21, Mauro Carvalho Chehab wrote:
> > Em Mon,  4 Jun 2018 13:46:14 +0200
> > Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> >   
> >> From: Hans Verkuil <hans.verkuil@cisco.com>
> >>
> >> Define the public request API.
> >>
> >> This adds the new MEDIA_IOC_REQUEST_ALLOC ioctl to allocate a request
> >> and two ioctls that operate on a request in order to queue the
> >> contents of the request to the driver and to re-initialize the
> >> request.  
> > 
> > It would be better if you had added the documentation stuff here...
> > I can't review this patch without first reviewing the documentation
> > for the new ioctls...  
> 
> I moved patch 29 to the front for the next version.

Thanks! Be sure to move other documentation patches to be together
with the respective code changes. Reviewing a /35 patch series
is hard enough even without needing to review stuff on some
random order.

Thanks,
Mauro

  reply	other threads:[~2018-07-03 10:04 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-04 11:46 [PATCHv15 00/35] Request API Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 01/35] uapi/linux/media.h: add request API Hans Verkuil
2018-07-03  9:21   ` Mauro Carvalho Chehab
2018-07-03  9:33     ` Hans Verkuil
2018-07-03 10:04       ` Mauro Carvalho Chehab [this message]
2018-06-04 11:46 ` [PATCHv15 02/35] media-request: implement media requests Hans Verkuil
2018-06-15  7:08   ` Hans Verkuil
2018-07-02  8:58     ` Tomasz Figa
2018-07-02  9:11       ` Hans Verkuil
2018-07-02 10:57         ` Tomasz Figa
2018-07-02 10:56   ` Tomasz Figa
2018-07-02 11:26     ` Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 03/35] media: doc: Add media-request.h header to documentation build Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 04/35] media-request: add media_request_get_by_fd Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 05/35] media-request: add media_request_object_find Hans Verkuil
2018-07-02 12:33   ` Tomasz Figa
2018-07-02 12:37     ` Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 06/35] v4l2-device.h: add v4l2_device_supports_requests() helper Hans Verkuil
2018-07-02 13:01   ` Sakari Ailus
2018-06-04 11:46 ` [PATCHv15 07/35] v4l2-dev: lock req_queue_mutex Hans Verkuil
2018-07-02 13:06   ` Tomasz Figa
2018-07-02 13:23     ` Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 08/35] videodev2.h: add request_fd field to v4l2_ext_controls Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 09/35] v4l2-ctrls: v4l2_ctrl_add_handler: add from_other_dev Hans Verkuil
2018-06-04 16:22   ` Hans Verkuil
2018-06-05 10:16     ` Philipp Zabel
2018-06-04 17:11   ` Ezequiel Garcia
2018-06-04 11:46 ` [PATCHv15 10/35] v4l2-ctrls: prepare internal structs for request API Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 11/35] v4l2-ctrls: alloc memory for p_req Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 12/35] v4l2-ctrls: use ref in helper instead of ctrl Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 13/35] v4l2-ctrls: add core request support Hans Verkuil
2018-06-04 17:18   ` Ezequiel Garcia
2018-06-15  7:18   ` Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 14/35] v4l2-ctrls: support g/s_ext_ctrls for requests Hans Verkuil
2018-06-15  7:20   ` Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 15/35] vb2: store userspace data in vb2_v4l2_buffer Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 16/35] davinci_vpfe: remove bogus vb2->state check Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 17/35] vb2: drop VB2_BUF_STATE_PREPARED, use bool prepared/synced instead Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 18/35] videodev2.h: Add request_fd field to v4l2_buffer Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 19/35] vb2: add init_buffer buffer op Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 20/35] videobuf2-core: embed media_request_object Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 21/35] videobuf2-core: integrate with media requests Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 22/35] videobuf2-v4l2: " Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 23/35] videobuf2-core: add request helper functions Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 24/35] videobuf2-v4l2: add vb2_request_queue/validate helpers Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 25/35] videobuf2-core: add uses_requests flag Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 26/35] videobuf2-v4l2: refuse qbuf if queue uses requests Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 27/35] v4l2-mem2mem: Simplify exiting the function in v4l2_m2m_try_schedule Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 28/35] v4l2-mem2mem: add vb2_m2m_request_queue Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 29/35] Documentation: v4l: document request API Hans Verkuil
2018-07-03 11:50   ` Mauro Carvalho Chehab
2018-07-03 13:02     ` Hans Verkuil
2018-07-03 14:08       ` Mauro Carvalho Chehab
2018-07-03 14:22         ` Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 30/35] vim2m: add media device Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 31/35] vim2m: use workqueue Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 32/35] vim2m: support requests Hans Verkuil
2018-06-04 17:15   ` Ezequiel Garcia
2018-06-04 11:46 ` [PATCHv15 33/35] vivid: add mc Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 34/35] vivid: add request support Hans Verkuil
2018-06-04 11:46 ` [PATCHv15 35/35] RFC: media-requests: add debugfs node Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180703070437.6343905b@coco.lan \
    --to=mchehab+samsung@kernel.org \
    --cc=hans.verkuil@cisco.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox