From: Gustavo Padovan <gustavo@padovan.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: "Linux Media Mailing List" <linux-media@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH for v4.19] drm_dp_cec.c: fix formatting typo: %pdH -> %phD
Date: Sat, 28 Jul 2018 15:53:38 -0300 [thread overview]
Message-ID: <20180728185338.GA14560@juma> (raw)
In-Reply-To: <f3720ddf-ec0f-cd22-46b6-720a5e2098f2@xs4all.nl>
On Tue, Jul 24, 2018 at 09:20:28PM +0200, Hans Verkuil wrote:
> This caused a kernel oops since %pdH interpreted the pointer
> as a struct file.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> drivers/gpu/drm/drm_dp_cec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_cec.c b/drivers/gpu/drm/drm_dp_cec.c
> index 87b67cc1ea58..a6cac47f6248 100644
> --- a/drivers/gpu/drm/drm_dp_cec.c
> +++ b/drivers/gpu/drm/drm_dp_cec.c
> @@ -157,7 +157,7 @@ static void drm_dp_cec_adap_status(struct cec_adapter *adap,
>
> if (drm_dp_read_desc(aux, &desc, true))
> return;
> - seq_printf(file, "OUI: %*pdH\n",
> + seq_printf(file, "OUI: %*phD\n",
> (int)sizeof(id->oui), id->oui);
> seq_printf(file, "ID: %*pE\n",
> (int)strnlen(id->device_id, sizeof(id->device_id)),
pushed to drm-misc-next-fixes for 4.19. Thanks.
Gustavo
prev parent reply other threads:[~2018-07-28 20:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 19:20 [PATCH for v4.19] drm_dp_cec.c: fix formatting typo: %pdH -> %phD Hans Verkuil
2018-07-28 18:53 ` Gustavo Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180728185338.GA14560@juma \
--to=gustavo@padovan.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox