[PATCH 1/1] mt9v111: Fix compiler warning by initialising a variable

[PATCH 1/1] mt9v111: Fix compiler warning by initialising a variable

[Sakari Ailus]

While this isn't a bug, initialise the variable to quash the warning.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/media/i2c/mt9v111.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
index da8f6ab91307..58d5f2224bff 100644
--- a/drivers/media/i2c/mt9v111.c
+++ b/drivers/media/i2c/mt9v111.c
@@ -884,7 +884,7 @@ static int mt9v111_set_format(struct v4l2_subdev *subdev,
 	struct v4l2_mbus_framefmt new_fmt;
 	struct v4l2_mbus_framefmt *__fmt;
 	unsigned int best_fit = ~0L;
-	unsigned int idx;
+	unsigned int idx = 0;
 	unsigned int i;
 
 	mutex_lock(&mt9v111->stream_mutex);
-- 
2.11.0

Re: [PATCH 1/1] mt9v111: Fix compiler warning by initialising a variable

[jacopo mondi]

[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]

Hi Sakari,

On Mon, Jul 30, 2018 at 10:26:27AM +0300, Sakari Ailus wrote:
> While this isn't a bug, initialise the variable to quash the warning.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  drivers/media/i2c/mt9v111.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
> index da8f6ab91307..58d5f2224bff 100644
> --- a/drivers/media/i2c/mt9v111.c
> +++ b/drivers/media/i2c/mt9v111.c
> @@ -884,7 +884,7 @@ static int mt9v111_set_format(struct v4l2_subdev *subdev,
>  	struct v4l2_mbus_framefmt new_fmt;
>  	struct v4l2_mbus_framefmt *__fmt;
>  	unsigned int best_fit = ~0L;
> -	unsigned int idx;
> +	unsigned int idx = 0;
>  	unsigned int i;
>

Thanks for this, but there is already a patch sent on Friday by Jasmin
addressing the warning

https://patchwork.kernel.org/patch/10547983/

>  	mutex_lock(&mt9v111->stream_mutex);
> --
> 2.11.0
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 1/1] mt9v111: Fix compiler warning by initialising a variable

[Sakari Ailus]

On Mon, Jul 30, 2018 at 09:51:25AM +0200, jacopo mondi wrote:
> Hi Sakari,
> 
> On Mon, Jul 30, 2018 at 10:26:27AM +0300, Sakari Ailus wrote:
> > While this isn't a bug, initialise the variable to quash the warning.
> >
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> >  drivers/media/i2c/mt9v111.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
> > index da8f6ab91307..58d5f2224bff 100644
> > --- a/drivers/media/i2c/mt9v111.c
> > +++ b/drivers/media/i2c/mt9v111.c
> > @@ -884,7 +884,7 @@ static int mt9v111_set_format(struct v4l2_subdev *subdev,
> >  	struct v4l2_mbus_framefmt new_fmt;
> >  	struct v4l2_mbus_framefmt *__fmt;
> >  	unsigned int best_fit = ~0L;
> > -	unsigned int idx;
> > +	unsigned int idx = 0;
> >  	unsigned int i;
> >
> 
> Thanks for this, but there is already a patch sent on Friday by Jasmin
> addressing the warning
> 
> https://patchwork.kernel.org/patch/10547983/

Ah, ok. I'll mark this as rejected then.

-- 
Sakari Ailus
sakari.ailus@linux.intel.com