public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: jacopo mondi <jacopo@jmondi.org>
To: "Jasmin J." <jasmin@anw.at>
Cc: linux-media@vger.kernel.org, mchehab+samsung@kernel.org,
	Jacopo Mondi <jacopo+renesas@jmondi.org>
Subject: Re: [PATCH] media: i2c: fix warning in Aptina MT9V111
Date: Mon, 30 Jul 2018 09:52:19 +0200	[thread overview]
Message-ID: <20180730075219.GF7615@w540> (raw)
In-Reply-To: <1532786089-15015-1-git-send-email-jasmin@anw.at>

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

Hi Jasmin,

On Sat, Jul 28, 2018 at 03:54:49PM +0200, Jasmin J. wrote:
> From: Jasmin Jessich <jasmin@anw.at>
>
> This fixes the "'idx' may be used uninitialized in this function"
> warning.
>
> Cc:  Jacopo Mondi <jacopo+renesas@jmondi.org>
> Signed-off-by: Jasmin Jessich <jasmin@anw.at>

Thanks for the patch

Acked-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
   j

> ---
>  drivers/media/i2c/mt9v111.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
> index da8f6ab..58d5f22 100644
> --- a/drivers/media/i2c/mt9v111.c
> +++ b/drivers/media/i2c/mt9v111.c
> @@ -884,7 +884,7 @@ static int mt9v111_set_format(struct v4l2_subdev *subdev,
>  	struct v4l2_mbus_framefmt new_fmt;
>  	struct v4l2_mbus_framefmt *__fmt;
>  	unsigned int best_fit = ~0L;
> -	unsigned int idx;
> +	unsigned int idx = 0;
>  	unsigned int i;
>
>  	mutex_lock(&mt9v111->stream_mutex);
> --
> 2.7.4
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2018-07-30  9:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-28 13:54 [PATCH] media: i2c: fix warning in Aptina MT9V111 Jasmin J.
2018-07-30  7:52 ` jacopo mondi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180730075219.GF7615@w540 \
    --to=jacopo@jmondi.org \
    --cc=jacopo+renesas@jmondi.org \
    --cc=jasmin@anw.at \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab+samsung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox