public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Daniel Scheller <d.scheller.oss@gmail.com>
Cc: mchehab@kernel.org, mchehab@s-opensource.com,
	linux-media@vger.kernel.org
Subject: Re: [PATCH] [media] dvb-frontends/tda18271c2dd: silence sparse fall through warning
Date: Mon, 30 Jul 2018 14:16:27 -0300	[thread overview]
Message-ID: <20180730141627.5d9f889e@coco.lan> (raw)
In-Reply-To: <20180624134250.8321-1-d.scheller.oss@gmail.com>

Em Sun, 24 Jun 2018 15:42:50 +0200
Daniel Scheller <d.scheller.oss@gmail.com> escreveu:

> From: Daniel Scheller <d.scheller@gmx.net>
> 
> Add a break statement in set_params() for the SYS_DVBT(2) case to silence
> this sparse warning:
> 
>     drivers/media/dvb-frontends/tda18271c2dd.c:1144:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> as reported in Hans' daily media_tree builds.
> 
> Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
> ---
>  drivers/media/dvb-frontends/tda18271c2dd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/dvb-frontends/tda18271c2dd.c b/drivers/media/dvb-frontends/tda18271c2dd.c
> index 2e1d36ae943b..fcffc7b4acf7 100644
> --- a/drivers/media/dvb-frontends/tda18271c2dd.c
> +++ b/drivers/media/dvb-frontends/tda18271c2dd.c
> @@ -1154,6 +1154,7 @@ static int set_params(struct dvb_frontend *fe)
>  		default:
>  			return -EINVAL;
>  		}
> +		break;

This actually seems to be a bug. Did you test this patch with
an actual hardware?

Regards,
Mauro

Thanks,
Mauro

      reply	other threads:[~2018-07-30 18:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-24 13:42 [PATCH] [media] dvb-frontends/tda18271c2dd: silence sparse fall through warning Daniel Scheller
2018-07-30 17:16 ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180730141627.5d9f889e@coco.lan \
    --to=mchehab+samsung@kernel.org \
    --cc=d.scheller.oss@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mchehab@s-opensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox