From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from relay7-d.mail.gandi.net ([217.70.183.200]:43197 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726080AbeHELkM (ORCPT ); Sun, 5 Aug 2018 07:40:12 -0400 Date: Sun, 5 Aug 2018 11:36:05 +0200 From: jacopo mondi To: kbuild test robot Cc: Jacopo Mondi , kbuild-all@01.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, Kieran Bingham , Sakari Ailus Subject: Re: [ragnatech:media-tree 273/382] drivers/media/i2c/mt9v111.c:801:10: error: implicit declaration of function 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'? Message-ID: <20180805093605.GI4528@w540> References: <201808050155.97R8Urh7%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sl5MdczEF/OU2Miu" Content-Disposition: inline In-Reply-To: <201808050155.97R8Urh7%fengguang.wu@intel.com> Sender: linux-media-owner@vger.kernel.org List-ID: --sl5MdczEF/OU2Miu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Sun, Aug 05, 2018 at 01:14:58AM +0800, kbuild test robot wrote: > tree: git://git.ragnatech.se/linux media-tree > head: 12f336c88090fb8004736fd4329184326a49673b > commit: aab7ed1c392703604fbdc5bd5005dfb61a0b32f9 [273/382] media: i2c: Add driver for Aptina MT9V111 > config: x86_64-randconfig-x010-201831 (attached as .config) > compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 > reproduce: > git checkout aab7ed1c392703604fbdc5bd5005dfb61a0b32f9 > # save the attached .config to linux build tree > make ARCH=x86_64 > > All error/warnings (new ones prefixed by >>): > > drivers/media/i2c/mt9v111.c: In function '__mt9v111_get_pad_format': > >> drivers/media/i2c/mt9v111.c:801:10: error: implicit declaration of function 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'? [-Werror=implicit-function-declaration] > return v4l2_subdev_get_try_format(&mt9v111->sd, cfg, pad); > ^~~~~~~~~~~~~~~~~~~~~~~~~~ I have received this notification a few times now, and it comes from the test build being run a kernel configured without the CONFIG_VIDEO_V4L2_SUBDEV_API symbol. The mt9v111 driver does not list CONFIG_VIDEO_V4L2_SUBDEV_API as a Kconfig dependency and the option does not get selected by the config generated by kbuild, I guess. Should I list CONFIG_VIDEO_V4L2_SUBDEV_API as an mt9v111 dependency with an incremental patch? > v4l2_subdev_notify_event > >> drivers/media/i2c/mt9v111.c:801:10: warning: return makes pointer from integer without a cast [-Wint-conversion] > return v4l2_subdev_get_try_format(&mt9v111->sd, cfg, pad); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format': > drivers/media/i2c/mt9v111.c:887:15: warning: 'idx' may be used uninitialized in this function [-Wmaybe-uninitialized] > unsigned int idx; > ^~~ > cc1: some warnings being treated as errors > > vim +801 drivers/media/i2c/mt9v111.c > > 791 > 792 static struct v4l2_mbus_framefmt *__mt9v111_get_pad_format( > 793 struct mt9v111_dev *mt9v111, > 794 struct v4l2_subdev_pad_config *cfg, > 795 unsigned int pad, > 796 enum v4l2_subdev_format_whence which) > 797 { > 798 switch (which) { > 799 case V4L2_SUBDEV_FORMAT_TRY: > 800 #if IS_ENABLED(CONFIG_MEDIA_CONTROLLER) > > 801 return v4l2_subdev_get_try_format(&mt9v111->sd, cfg, pad); > 802 #else > 803 return &cfg->try_fmt; > 804 #endif > 805 case V4L2_SUBDEV_FORMAT_ACTIVE: > 806 return &mt9v111->fmt; > 807 default: > 808 return NULL; > 809 } > 810 } > 811 > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation --sl5MdczEF/OU2Miu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJbZsUFAAoJEHI0Bo8WoVY8JuYP/3az90qzAHxF1zAIDa87QN1l xchI/o60f1SD+itdlAs4rFvRBzlf5k38wbm+pCe+nz7AVXrBlIMT7KO/WsgfCuDQ jdNzHKa+EUmiCfWKMXvZzRWl3ncjayNhAYIPN0g32Clotq1872CzA2E+UZi0kguQ 54OJfXOjsUyjUabsXnxVhOli1OhqelI6J7S8Gi3bumKKm70hslgjX92jwFMP/d0o N+Hdah05W+yUcZ7iDRe/4qH9Cn4TB/sHYFrSt++tgAcChnXpC34tztWYIjx5H1pS J9syy3uEDaoM6CUnvKp42yeHA8wtylTv7GoH6waUTCZEkfqRaE1dvrJwZgW0niTm uBli1r1UhETeam5S/My0xVYCqY11iOHcxE25PdKbA9IZCw2DG5+c3eYYL5JyPimX yM1LkDTMDi77MaLprepucdVOcHGOwHMIKS1+7Ox3BUGSfscmHshvjzKneCHH/gua ES+eanthBS+BOgLM4695oXwLA2sRs4XaR+fRsW0zbb7WlTDsRoLe24/PP0WAZt2P OlpH7jEwljVhDxPI4nObMs22F1f/c4k1hZMY4xSr34gsy1kXUfQWDIZJWJUcV3nX 4sSZh75wlf8bv54ixAOVNzd/YVOd1p3qnzs/3BGN9E7zHg2VA4scoYr6SSakCXrl 3+n7KSqktgA4QUXWo4QQ =Snuf -----END PGP SIGNATURE----- --sl5MdczEF/OU2Miu--