linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: mchehab@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com
Cc: kernel@pengutronix.de, devicetree@vger.kernel.org,
	p.zabel@pengutronix.de, javierm@redhat.com,
	laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com,
	afshin.nasser@gmail.com, linux-media@vger.kernel.org
Subject: [PATCH v2 6/7] [media] tvp5150: initialize subdev before parsing device tree
Date: Mon, 13 Aug 2018 11:25:07 +0200	[thread overview]
Message-ID: <20180813092508.1334-7-m.felsch@pengutronix.de> (raw)
In-Reply-To: <20180813092508.1334-1-m.felsch@pengutronix.de>

From: Michael Tretter <m.tretter@pengutronix.de>

There are several debug prints in the tvp5150_parse_dt() function, which
do not print the prefix, because the v4l2_subdev is not initialized, yet.

Initialize the v4l2_subdev before parsing the device tree to fix the
debug messages.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 drivers/media/i2c/tvp5150.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 825dcf3a9d83..e736f609fecd 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -2032,6 +2032,9 @@ static int tvp5150_probe(struct i2c_client *c,
 
 	core->regmap = map;
 	sd = &core->sd;
+	v4l2_i2c_subdev_init(sd, c, &tvp5150_ops);
+	sd->internal_ops = &tvp5150_internal_ops;
+	sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
 
 	if (IS_ENABLED(CONFIG_OF) && np) {
 		res = tvp5150_parse_dt(core, np);
@@ -2044,10 +2047,6 @@ static int tvp5150_probe(struct i2c_client *c,
 		core->mbus_type = V4L2_MBUS_BT656;
 	}
 
-	v4l2_i2c_subdev_init(sd, c, &tvp5150_ops);
-	sd->internal_ops = &tvp5150_internal_ops;
-	sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
-
 	res = tvp5150_mc_init(sd);
 	if (res)
 		goto err_cleanup_dt;
-- 
2.18.0

  parent reply	other threads:[~2018-08-13 12:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-13  9:25 [PATCH v2 0/7] TVP5150 fixes and new features Marco Felsch
2018-08-13  9:25 ` [PATCH v2 1/7] [media] tvp5150: add input source selection of_graph support Marco Felsch
2018-09-14 13:31   ` Sakari Ailus
2018-09-14 17:54     ` Marco Felsch
2018-08-13  9:25 ` [PATCH v2 2/7] [media] dt-bindings: tvp5150: Add input port connectors DT bindings Marco Felsch
2018-08-13 21:41   ` Rob Herring
2018-08-14 16:10     ` Marco Felsch
2018-08-13  9:25 ` [PATCH v2 3/7] [media] v4l2-subdev: add stubs for v4l2_subdev_get_try_* Marco Felsch
2018-08-13  9:25 ` [PATCH v2 4/7] [media] v4l2-subdev: fix v4l2_subdev_get_try_* dependency Marco Felsch
2018-09-14 13:25   ` Sakari Ailus
2018-09-14 18:10     ` Marco Felsch
2018-08-13  9:25 ` [PATCH v2 5/7] [media] tvp5150: add FORMAT_TRY support for get/set selection handlers Marco Felsch
2018-08-13  9:25 ` Marco Felsch [this message]
2018-08-13  9:25 ` [PATCH v2 7/7] [media] tvp5150: add s_power callback Marco Felsch
2018-09-14 13:23   ` Sakari Ailus
2018-09-14 18:20     ` Marco Felsch
2018-09-14 18:57       ` Mauro Carvalho Chehab
2018-09-18  9:51         ` Marco Felsch
2018-09-14  8:43 ` [PATCH v2 0/7] TVP5150 fixes and new features Marco Felsch
2018-09-14  9:37   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180813092508.1334-7-m.felsch@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=afshin.nasser@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=javierm@redhat.com \
    --cc=kernel@pengutronix.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).