From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from gofer.mess.org ([88.97.38.141]:33073 "EHLO gofer.mess.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727353AbeIJPda (ORCPT ); Mon, 10 Sep 2018 11:33:30 -0400 Date: Mon, 10 Sep 2018 11:40:02 +0100 From: Sean Young To: Sakari Ailus Cc: linux-media@vger.kernel.org, Rob Herring , Ivaylo Dimitrov , Pali =?iso-8859-1?Q?Roh=E1r?= , Pavel Machek , Timo Kokkonen , Tony Lindgren Subject: Re: [PATCH v3 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver Message-ID: <20180910104002.gngh2yphccgznf23@gofer.mess.org> References: <20180713122230.19278-1-sean@mess.org> <20180831080723.3e6uwa5lsjfklhof@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180831080723.3e6uwa5lsjfklhof@valkosipuli.retiisi.org.uk> Sender: linux-media-owner@vger.kernel.org List-ID: On Fri, Aug 31, 2018 at 11:07:23AM +0300, Sakari Ailus wrote: > Hi Sean, > > On Fri, Jul 13, 2018 at 01:22:29PM +0100, Sean Young wrote: > > The generic pwm-ir-tx driver should work for the Nokia n900. > > > > Compile tested only. > > > > Cc: Rob Herring > > Cc: Ivaylo Dimitrov > > Cc: Pali Rohár > > Cc: Pavel Machek > > Cc: Timo Kokkonen > > Cc: Tony Lindgren > > Signed-off-by: Sean Young > > --- > > arch/arm/boot/dts/omap3-n900.dts | 2 +- > > drivers/media/rc/pwm-ir-tx.c | 1 + > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts > > index 182a53991c90..fd12dea15799 100644 > > --- a/arch/arm/boot/dts/omap3-n900.dts > > +++ b/arch/arm/boot/dts/omap3-n900.dts > > @@ -154,7 +154,7 @@ > > }; > > > > ir: n900-ir { > > - compatible = "nokia,n900-ir"; > > + compatible = "nokia,n900-ir", "pwm-ir-tx"; > > pwms = <&pwm9 0 26316 0>; /* 38000 Hz */ > > }; > > > > diff --git a/drivers/media/rc/pwm-ir-tx.c b/drivers/media/rc/pwm-ir-tx.c > > index 27d0f5837a76..272947b430c8 100644 > > --- a/drivers/media/rc/pwm-ir-tx.c > > +++ b/drivers/media/rc/pwm-ir-tx.c > > @@ -30,6 +30,7 @@ struct pwm_ir { > > }; > > > > static const struct of_device_id pwm_ir_of_match[] = { > > + { .compatible = "nokia,n900-ir" }, > > Is this change needed as well? I suppose you could add it later if there's > a need to e.g. do something differently for the N900 IR transmitter. This is to ensure compatibility of a new kernel with an old board dtb. > It'd be nice if someone tested it, too... That would be nice, but I don't have the hardware and so far I there has been noone willing/able to test it. Sean