* [PATCH] udmabuf: fix error code in map_udmabuf()
@ 2018-09-14 6:56 Dan Carpenter
2018-09-14 9:45 ` Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-09-14 6:56 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: Sumit Semwal, dri-devel, linux-media, linaro-mm-sig,
kernel-janitors
We accidentally forgot to set "ret" on this error path so it means we
return NULL instead of an error pointer. The caller checks for NULL and
changes it to an error pointer so it doesn't cause an issue at run time.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
index 9edabce0b8ab..5b44ef226904 100644
--- a/drivers/dma-buf/udmabuf.c
+++ b/drivers/dma-buf/udmabuf.c
@@ -61,8 +61,10 @@ static struct sg_table *map_udmabuf(struct dma_buf_attachment *at,
GFP_KERNEL);
if (ret < 0)
goto err;
- if (!dma_map_sg(at->dev, sg->sgl, sg->nents, direction))
+ if (!dma_map_sg(at->dev, sg->sgl, sg->nents, direction)) {
+ ret = -EINVAL;
goto err;
+ }
return sg;
err:
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-14 14:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-14 6:56 [PATCH] udmabuf: fix error code in map_udmabuf() Dan Carpenter
2018-09-14 9:45 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox