linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: mchehab@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com
Cc: kernel@pengutronix.de, devicetree@vger.kernel.org,
	p.zabel@pengutronix.de, javierm@redhat.com,
	laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com,
	afshin.nasser@gmail.com, linux-media@vger.kernel.org
Subject: Re: [PATCH v2 0/7] TVP5150 fixes and new features
Date: Fri, 14 Sep 2018 10:43:03 +0200	[thread overview]
Message-ID: <20180914084303.pvqm35cbe6vznoci@pengutronix.de> (raw)
In-Reply-To: <20180813092508.1334-1-m.felsch@pengutronix.de>

Hi,

since I sent this series I only got feedback from Rob.

Regards,
Marco

On 18-08-13 11:25, Marco Felsch wrote:
> Hi,
> 
> this is my v2 with the integrated reviews from my v1 [1]. Since Mauro
> applied the most patches from my v1 to his experimental/tvp5150-3
> branch [2], this series only contains those which aren't applied.
> 
> Patches I changed contain a changelog, so I will omit these here.
> 
> Patch ('[media] tvp5150: add FORMAT_TRY support for get/set selection
> handlers') throws a compile error. Therefore I added two v4l2-subdev.h
> patches which should fix the error in a common way.
> 
> Patch ('[media] tvp5150: add s_power callback') is new too. I forget
> them in my v1. This patch address the interrupt enable/disable handling.
> Now it is possible to pause streaming and keep the interrupts on.
> 
> The changes I made in the ('[media] tvp5150: add input source selection
> of_graph support') patch are based on the the RFC [3] and discussion [4].
> I dropped patch ('[media] tvp5150: Change default input source selection
> behaviour') since the default input source selectopn is setup during the
> .registered() callback now.
> 
> I've tested this series on a customer dt-based board. Unfortunately I
> haven't a device which use the em28xx driver. So other tester a welcome :)
> 
> [1] https://www.spinics.net/lists/devicetree/msg236650.html
> [2] https://git.linuxtv.org/mchehab/experimental.git/log/?h=tvp5150-3
> [3] https://www.spinics.net/lists/devicetree/msg243181.html
> [4] https://www.spinics.net/lists/devicetree/msg243840.html
> 
> Regards,
> Marco
> 
> Marco Felsch (6):
>   [media] tvp5150: add input source selection of_graph support
>   [media] dt-bindings: tvp5150: Add input port connectors DT bindings
>   [media] v4l2-subdev: add stubs for v4l2_subdev_get_try_*
>   [media] v4l2-subdev: fix v4l2_subdev_get_try_* dependency
>   [media] tvp5150: add FORMAT_TRY support for get/set selection handlers
>   [media] tvp5150: add s_power callback
> 
> Michael Tretter (1):
>   [media] tvp5150: initialize subdev before parsing device tree
> 
>  .../devicetree/bindings/media/i2c/tvp5150.txt | 191 +++++-
>  drivers/media/i2c/tvp5150.c                   | 611 +++++++++++++++---
>  include/media/v4l2-subdev.h                   | 111 ++--
>  3 files changed, 776 insertions(+), 137 deletions(-)
> 
> -- 
> 2.18.0
> 
> 

  parent reply	other threads:[~2018-09-14 13:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-13  9:25 [PATCH v2 0/7] TVP5150 fixes and new features Marco Felsch
2018-08-13  9:25 ` [PATCH v2 1/7] [media] tvp5150: add input source selection of_graph support Marco Felsch
2018-09-14 13:31   ` Sakari Ailus
2018-09-14 17:54     ` Marco Felsch
2018-08-13  9:25 ` [PATCH v2 2/7] [media] dt-bindings: tvp5150: Add input port connectors DT bindings Marco Felsch
2018-08-13 21:41   ` Rob Herring
2018-08-14 16:10     ` Marco Felsch
2018-08-13  9:25 ` [PATCH v2 3/7] [media] v4l2-subdev: add stubs for v4l2_subdev_get_try_* Marco Felsch
2018-08-13  9:25 ` [PATCH v2 4/7] [media] v4l2-subdev: fix v4l2_subdev_get_try_* dependency Marco Felsch
2018-09-14 13:25   ` Sakari Ailus
2018-09-14 18:10     ` Marco Felsch
2018-08-13  9:25 ` [PATCH v2 5/7] [media] tvp5150: add FORMAT_TRY support for get/set selection handlers Marco Felsch
2018-08-13  9:25 ` [PATCH v2 6/7] [media] tvp5150: initialize subdev before parsing device tree Marco Felsch
2018-08-13  9:25 ` [PATCH v2 7/7] [media] tvp5150: add s_power callback Marco Felsch
2018-09-14 13:23   ` Sakari Ailus
2018-09-14 18:20     ` Marco Felsch
2018-09-14 18:57       ` Mauro Carvalho Chehab
2018-09-18  9:51         ` Marco Felsch
2018-09-14  8:43 ` Marco Felsch [this message]
2018-09-14  9:37   ` [PATCH v2 0/7] TVP5150 fixes and new features Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180914084303.pvqm35cbe6vznoci@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=afshin.nasser@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=javierm@redhat.com \
    --cc=kernel@pengutronix.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).