From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:51536 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727171AbeIUAi7 (ORCPT ); Thu, 20 Sep 2018 20:38:59 -0400 Date: Thu, 20 Sep 2018 20:54:05 +0200 From: Pavel Machek To: Ricardo Ribalda Delgado Cc: Sakari Ailus , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Verkuil , Laurent Pinchart Subject: Re: [PATCH v2 2/4] [media] ad5820: Add support for enable pin Message-ID: <20180920185405.GA26589@amd> References: <20180920161912.17063-2-ricardo.ribalda@gmail.com> <20180920184552.4919-1-ricardo.ribalda@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8t9RHnE3ZwKMSgU+" Content-Disposition: inline In-Reply-To: <20180920184552.4919-1-ricardo.ribalda@gmail.com> Sender: linux-media-owner@vger.kernel.org List-ID: --8t9RHnE3ZwKMSgU+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2018-09-20 20:45:52, Ricardo Ribalda Delgado wrote: > This patch adds support for a programmable enable pin. It can be used in > situations where the ANA-vcc is not configurable (dummy-regulator), or > just to have a more fine control of the power saving. >=20 > The use of the enable pin is optional. >=20 > Signed-off-by: Ricardo Ribalda Delgado Do we really want to do that? Would it make more sense to add gpio-regulator and connect ad5820 to it in such case? Pavel =09 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --8t9RHnE3ZwKMSgU+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAluj7M0ACgkQMOfwapXb+vKnFwCeOGjLmLsL7xRxaSmp7WtaJBrg UfwAn0zvxfYVEjXP1oHHMFXDviuVsrag =fgHJ -----END PGP SIGNATURE----- --8t9RHnE3ZwKMSgU+--