From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.bootlin.com ([62.4.15.54]:41135 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727392AbeIUUHX (ORCPT ); Fri, 21 Sep 2018 16:07:23 -0400 Date: Fri, 21 Sep 2018 16:18:05 +0200 From: Maxime Ripard To: Kishon Vijay Abraham I Cc: Boris Brezillon , Thomas Petazzoni , Laurent Pinchart , linux-media@vger.kernel.org, Archit Taneja , Andrzej Hajda , Chen-Yu Tsai , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Krzysztof Witos , Rafal Ciepiela Subject: Re: [PATCH 02/10] phy: Add configuration interface Message-ID: <20180921141805.s4u224xzmtii66dg@flea> References: <1ed01c1f-76d5-fa96-572b-9bfd269ad11b@ti.com> <20180906145622.kwxvkcuerbeqsj6b@flea> <1a169fad-72b7-fac0-1254-cac5d8304740@ti.com> <20180912084242.skxbwbgluakakyg6@flea> <20180919121436.ztjnxofe66quddeq@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zldsfftxvy2fxfnd" Content-Disposition: inline In-Reply-To: <20180919121436.ztjnxofe66quddeq@flea> Sender: linux-media-owner@vger.kernel.org List-ID: --zldsfftxvy2fxfnd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 19, 2018 at 02:14:36PM +0200, Maxime Ripard wrote: > > I'm sorry but I'm not convinced a consumer driver should have all the d= etails > > that are added in phy_configure_opts_mipi_dphy. >=20 > If it can convince you, here is the parameters that are needed by all > the MIPI-DSI drivers currently in Linux to configure their PHY: >=20 > - cdns-dsi (drivers/gpu/drm/bridge/cdns-dsi.c) > - hs_clk_rate > - lanes > - videomode >=20 > - kirin (drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c) > - hs_exit > - hs_prepare > - hs_trail > - hs_zero > - lpx > - ta_get > - ta_go > - wakeup >=20 > - msm (drivers/gpu/drm/msm/dsi/*) > - clk_post > - clk_pre > - clk_prepare > - clk_trail > - clk_zero > - hs_clk_rate > - hs_exit > - hs_prepare > - hs_trail > - hs_zero > - lp_clk_rate > - ta_get > - ta_go > - ta_sure >=20 > - mtk (drivers/gpu/drm/mediatek/mtk_dsi.c) > - hs_clk_rate > - hs_exit > - hs_prepare > - hs_trail > - hs_zero > - lpx >=20 > - sun4i (drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c) > - clk_post > - clk_pre > - clk_prepare > - clk_zero > - hs_prepare > - hs_trail > - lanes > - lp_clk_rate >=20 > - tegra (drivers/gpu/drm/tegra/dsi.c) > - clk_post > - clk_pre > - clk_prepare > - clk_trail > - clk_zero > - hs_exit > - hs_prepare > - hs_trail > - hs_zero > - lpx > - ta_get > - ta_go > - ta_sure >=20 > - vc4 (drivers/gpu/drm/vc4/vc4_dsi.c) > - hs_clk_rate > - lanes >=20 > Now, for MIPI-CSI receivers: >=20 > - marvell-ccic (drivers/media/platform/marvell-ccic/mcam-core.c) > - clk_term_en > - clk_settle > - d_term_en > - hs_settle > - lp_clk_rate >=20 > - omap4iss (drivers/staging/media/omap4iss/iss_csiphy.c) > - clk_miss > - clk_settle > - clk_term > - hs_settle > - hs_term > - lanes >=20 > - rcar-vin (drivers/media/platform/rcar-vin/rcar-csi2.c) > - hs_clk_rate > - lanes >=20 > - ti-vpe (drivers/media/platform/ti-vpe/cal.c) > - clk_term_en > - d_term_en > - hs_settle > - hs_term >=20 > So the timings expressed in the structure are the set of all the ones > currently used in the tree by DSI and CSI drivers. I would consider > that a good proof that it would be useful. >=20 > Note that at least cdns-dsi, exynos4-is > (drivers/media/platform/exynos4-is/mipi-csis.c), kirin, sun4i, msm, > mtk, omap4iss, plus the v4l2 drivers cdns-csi2tx and cdns-csi2rx I > want to convert, have already either a driver for their DPHY using the > phy framework plus a configuration function, or a design very similar > that could be migrated to such an API. There's also a patch set currently being submitted that uses a phy driver + custom functions: https://lore.kernel.org/patchwork/cover/988959/ Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --zldsfftxvy2fxfnd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAluk/ZwACgkQ0rTAlCFN r3QPsA//TW4vFjvM51035KuuVaJi4y5Tu7v4ock6POiSrP6k1buND4KfJXXU+iSj Z+OWrLSK0iDFtFLeZ2oN6dFucpHZdaHvZH+KWrrXkKj0zZVPS8eBuKnmQZOqEn8J DPvsEK2ckfcmtSYidr10APVWc2WbfUAgLBj0ZcGtGt/zELiQeW5cc9DRq5g5F12n HuVLrIi1/1GvzZYCI+oqQLga7D/7KTZ5ssD+zzQ2V4fA1p26ijQaNoIzRW05VB5v MHnJyoEwBr/HNO/zsVd9iihRv6S+/muQpXB2hBC/rDb1mPMbwN/U8M+Gc+9/fhN1 tsQlN6rBlhlpmJA5maaLvcoyvNjU4qTSp/dPtXhn6Xr4ajJQGQRasEuZo22eeC5I tZQoJaWABsBTz37NZOxpww0NkaDa7RmRg0iyhgGqmwSfj2AeTS/u7/vg2m0kbWpX 9c5bxE5WbuzqQlgvEAWJ/r++Ajl3d7OWT2TJCc7659OO6ozQQk5i+z4Q9MLSdhKj W0MacoUy3GbgmRv3Xg/kMa1aDUPiEhTr2odTZF2xsCrlHNRiCHJHXaFdsm4UOqik 5Qn9OXSORVS92xepO+XalE5KAy0N2ERgd0F7DXaou6BR04D0HWrcFEOxvuixFPwi FaSqIJ8ZifBWamfb5fhnMbIDxacQcTUAcQsYxiC6XkXG0A2cIqQ= =76Ph -----END PGP SIGNATURE----- --zldsfftxvy2fxfnd--