From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: hverkuil@xs4all.nl, tfiga@chromium.org, bingbu.cao@intel.com,
jian.xu.zheng@intel.com, rajmohan.mani@intel.com,
tian.shu.qiu@intel.com, ricardo.ribalda@gmail.com,
grundler@chromium.org, ping-chung.chen@intel.com,
andy.yeh@intel.com, jim.lai@intel.com, helmut.grohne@intenta.de,
laurent.pinchart@ideasonboard.com, snawrocki@kernel.org
Subject: [PATCH 0/5] Add units to controls
Date: Tue, 25 Sep 2018 13:14:29 +0300 [thread overview]
Message-ID: <20180925101434.20327-1-sakari.ailus@linux.intel.com> (raw)
Hi all,
This set adds a few things to the current control framework in terms of
what kind of information the user space may have on controls. It adds
support for units and prefixes, exponential base as well as information on
whether a control is linear or exponential, to struct v4l2_query_ext_ctrl.
The smiapp driver gains support for the feature. In the near term, some
controls could also be assigned the unit automatically. The pixel rate,
for instance. Fewer driver changes would be needed this way. A driver
could override the value if there's a need to.
I think I'll merge the undefined and no unit cases. Same for the
exponential base actually --- the flag can be removed, too...
Regarding Ricardo's suggestion --- I was thinking of adding a control flag
(yes, there are a few bits available) to tell how to round the value. The
user could use the TRY_EXT_CTRLS IOCTL to figure out the next (or
previous) control value by incrementing the current value and setting the
appropriate flag. This is out of the scope of this set though.
Comments, questions?
Sakari Ailus (5):
videodev2.h: Use 8 hexadecimals (32 bits) for control flags
v4l: controls: Add support for exponential bases, prefixes and units
Documentation: media: Document control exponential bases, units,
prefixes
v4l: controls: QUERY_EXT_CTRL support for base, prefix and unit
smiapp: Set control units
Documentation/media/uapi/v4l/extended-controls.rst | 2 +
Documentation/media/uapi/v4l/vidioc-queryctrl.rst | 174 +++++++++++++++++++--
Documentation/media/videodev2.h.rst.exceptions | 22 +++
drivers/media/i2c/smiapp/smiapp-core.c | 16 +-
drivers/media/v4l2-core/v4l2-ctrls.c | 3 +
include/media/v4l2-ctrls.h | 2 +
include/uapi/linux/videodev2.h | 54 +++++--
7 files changed, 242 insertions(+), 31 deletions(-)
--
2.11.0
next reply other threads:[~2018-09-25 16:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 10:14 Sakari Ailus [this message]
2018-09-25 10:14 ` [PATCH 1/5] videodev2.h: Use 8 hexadecimals (32 bits) for control flags Sakari Ailus
2018-09-28 13:16 ` Laurent Pinchart
2018-09-28 13:48 ` Hans Verkuil
2018-09-25 10:14 ` [PATCH 2/5] v4l: controls: Add support for exponential bases, prefixes and units Sakari Ailus
2018-09-28 14:00 ` Hans Verkuil
2018-10-01 9:27 ` Helmut Grohne
2018-10-01 9:48 ` Hans Verkuil
2018-11-14 9:09 ` Tomasz Figa
2018-10-14 6:14 ` Pavel Machek
2018-09-25 10:14 ` [PATCH 3/5] Documentation: media: Document control exponential bases, units, prefixes Sakari Ailus
2018-09-25 10:39 ` Helmut Grohne
2018-09-25 10:51 ` Sakari Ailus
2018-09-28 14:20 ` Hans Verkuil
2018-09-25 10:14 ` [PATCH 4/5] v4l: controls: QUERY_EXT_CTRL support for base, prefix and unit Sakari Ailus
2018-09-26 22:40 ` kbuild test robot
2018-09-28 14:23 ` Hans Verkuil
2018-09-25 10:14 ` [PATCH 5/5] smiapp: Set control units Sakari Ailus
2018-09-28 14:28 ` Hans Verkuil
2018-09-25 11:48 ` [PATCH 0/5] Add units to controls Helmut Grohne
2018-09-25 12:30 ` Sakari Ailus
2018-09-26 10:24 ` Helmut Grohne
2018-09-28 13:25 ` Laurent Pinchart
2018-09-28 14:36 ` Hans Verkuil
2018-10-03 9:15 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925101434.20327-1-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andy.yeh@intel.com \
--cc=bingbu.cao@intel.com \
--cc=grundler@chromium.org \
--cc=helmut.grohne@intenta.de \
--cc=hverkuil@xs4all.nl \
--cc=jian.xu.zheng@intel.com \
--cc=jim.lai@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=ping-chung.chen@intel.com \
--cc=rajmohan.mani@intel.com \
--cc=ricardo.ribalda@gmail.com \
--cc=snawrocki@kernel.org \
--cc=tfiga@chromium.org \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox