From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: hverkuil@xs4all.nl, tfiga@chromium.org, bingbu.cao@intel.com,
jian.xu.zheng@intel.com, rajmohan.mani@intel.com,
tian.shu.qiu@intel.com, ricardo.ribalda@gmail.com,
grundler@chromium.org, ping-chung.chen@intel.com,
andy.yeh@intel.com, jim.lai@intel.com, helmut.grohne@intenta.de,
laurent.pinchart@ideasonboard.com, snawrocki@kernel.org
Subject: [PATCH 4/5] v4l: controls: QUERY_EXT_CTRL support for base, prefix and unit
Date: Tue, 25 Sep 2018 13:14:33 +0300 [thread overview]
Message-ID: <20180925101434.20327-5-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20180925101434.20327-1-sakari.ailus@linux.intel.com>
Add support for conveying the information set by the driver to the user
space.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/v4l2-core/v4l2-ctrls.c | 3 +++
include/media/v4l2-ctrls.h | 2 ++
2 files changed, 5 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c
index ee006d34c19f0..8d2931b0a4701 100644
--- a/drivers/media/v4l2-core/v4l2-ctrls.c
+++ b/drivers/media/v4l2-core/v4l2-ctrls.c
@@ -2732,6 +2732,9 @@ int v4l2_query_ext_ctrl(struct v4l2_ctrl_handler *hdl, struct v4l2_query_ext_ctr
qc->minimum = ctrl->minimum;
qc->maximum = ctrl->maximum;
qc->default_value = ctrl->default_value;
+ qc->base = ctrl->base;
+ qc->prefix = ctrl->prefix;
+ qc->unit = ctrl->unit;
if (ctrl->type == V4L2_CTRL_TYPE_MENU
|| ctrl->type == V4L2_CTRL_TYPE_INTEGER_MENU)
qc->step = 1;
diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
index f615ba1b29dd9..d6aaf45b70381 100644
--- a/include/media/v4l2-ctrls.h
+++ b/include/media/v4l2-ctrls.h
@@ -220,6 +220,8 @@ struct v4l2_ctrl {
u32 elem_size;
u32 dims[V4L2_CTRL_MAX_DIMS];
u32 nr_of_dims;
+ u8 base, unit;
+ u16 prefix;
union {
u64 step;
u64 menu_skip_mask;
--
2.11.0
next prev parent reply other threads:[~2018-09-25 16:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 10:14 [PATCH 0/5] Add units to controls Sakari Ailus
2018-09-25 10:14 ` [PATCH 1/5] videodev2.h: Use 8 hexadecimals (32 bits) for control flags Sakari Ailus
2018-09-28 13:16 ` Laurent Pinchart
2018-09-28 13:48 ` Hans Verkuil
2018-09-25 10:14 ` [PATCH 2/5] v4l: controls: Add support for exponential bases, prefixes and units Sakari Ailus
2018-09-28 14:00 ` Hans Verkuil
2018-10-01 9:27 ` Helmut Grohne
2018-10-01 9:48 ` Hans Verkuil
2018-11-14 9:09 ` Tomasz Figa
2018-10-14 6:14 ` Pavel Machek
2018-09-25 10:14 ` [PATCH 3/5] Documentation: media: Document control exponential bases, units, prefixes Sakari Ailus
2018-09-25 10:39 ` Helmut Grohne
2018-09-25 10:51 ` Sakari Ailus
2018-09-28 14:20 ` Hans Verkuil
2018-09-25 10:14 ` Sakari Ailus [this message]
2018-09-26 22:40 ` [PATCH 4/5] v4l: controls: QUERY_EXT_CTRL support for base, prefix and unit kbuild test robot
2018-09-28 14:23 ` Hans Verkuil
2018-09-25 10:14 ` [PATCH 5/5] smiapp: Set control units Sakari Ailus
2018-09-28 14:28 ` Hans Verkuil
2018-09-25 11:48 ` [PATCH 0/5] Add units to controls Helmut Grohne
2018-09-25 12:30 ` Sakari Ailus
2018-09-26 10:24 ` Helmut Grohne
2018-09-28 13:25 ` Laurent Pinchart
2018-09-28 14:36 ` Hans Verkuil
2018-10-03 9:15 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925101434.20327-5-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andy.yeh@intel.com \
--cc=bingbu.cao@intel.com \
--cc=grundler@chromium.org \
--cc=helmut.grohne@intenta.de \
--cc=hverkuil@xs4all.nl \
--cc=jian.xu.zheng@intel.com \
--cc=jim.lai@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=ping-chung.chen@intel.com \
--cc=rajmohan.mani@intel.com \
--cc=ricardo.ribalda@gmail.com \
--cc=snawrocki@kernel.org \
--cc=tfiga@chromium.org \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox