From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>,
Keiichi Watanabe <keiichiw@chromium.org>,
linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-kernel@vger.kernel.org, tfiga@chromium.org,
jcliang@chromium.org, shik@chromium.org
Subject: Re: [PATCH] media: vivid: Support 480p for webcam capture
Date: Mon, 8 Oct 2018 16:00:29 -0300 [thread overview]
Message-ID: <20181008160029.1bd1f5a8@coco.lan> (raw)
In-Reply-To: <931ca67d-3ac6-afc1-f933-c9733d561767@xs4all.nl>
Em Mon, 8 Oct 2018 20:31:10 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> > (gdb) list *vivid_fillbuff+0x1e9b
> > 0x1936b is in vivid_fillbuff (drivers/media/platform/vivid/vivid-kthread-cap.c:495).
> > 490 ms % 1000,
> > 491 buf->vb.sequence,
> > 492 (dev->field_cap == V4L2_FIELD_ALTERNATE) ?
> > 493 (buf->vb.field == V4L2_FIELD_TOP ?
> > 494 " top" : " bottom") : "");
> > 495 tpg_gen_text(tpg, basep, line++ * line_height, 16, str);
> > 496 }
> > 497 if (dev->osd_mode == 0) {
> > 498 snprintf(str, sizeof(str), " %dx%d, input %d ",
> > 499 dev->src_rect.width, dev->src_rect.height, dev->input);
> >
>
> There is a bug with hflip handling in that function. Nothing to do with the
> resolution. I could reproduce it by just checking the hflip control.
> I'll investigate.
Ah! Well, as I said, I got it only once last week while trying to use
vivid for some event racing test. I didn't have time to actually
seek. On that time, the bug only manifested when I changed the frame
rate.
Thanks,
Mauro
next prev parent reply other threads:[~2018-10-09 2:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 7:06 [PATCH] media: vivid: Support 480p for webcam capture Keiichi Watanabe
2018-10-03 7:08 ` Keiichi Watanabe
2018-10-03 11:16 ` Kieran Bingham
2018-10-05 9:18 ` Hans Verkuil
2018-10-06 10:29 ` Keiichi Watanabe
2018-10-08 8:35 ` Kieran Bingham
2018-10-08 9:00 ` Hans Verkuil
2018-10-08 9:47 ` Kieran Bingham
2018-10-03 11:14 ` Kieran Bingham
2018-10-08 17:03 ` Mauro Carvalho Chehab
2018-10-08 17:53 ` Hans Verkuil
2018-10-08 18:23 ` Mauro Carvalho Chehab
2018-10-08 18:28 ` Mauro Carvalho Chehab
2018-10-08 18:31 ` Hans Verkuil
2018-10-08 19:00 ` Mauro Carvalho Chehab [this message]
2018-10-09 6:01 ` Keiichi Watanabe
2018-10-09 6:33 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008160029.1bd1f5a8@coco.lan \
--to=mchehab+samsung@kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=jcliang@chromium.org \
--cc=keiichiw@chromium.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=shik@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox