From: Sasha Levin <sashal@kernel.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: stable@vger.kernel.org,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH for v4.9] Revert "media: videobuf2-core: don't call memop 'finish' when queueing"
Date: Fri, 23 Nov 2018 14:52:05 -0500 [thread overview]
Message-ID: <20181123195205.GL1917@sasha-vm> (raw)
In-Reply-To: <d9f73b7c-fc28-77ff-8c28-a565e2879efe@xs4all.nl>
On Thu, Nov 22, 2018 at 12:43:56PM +0100, Hans Verkuil wrote:
>This reverts commit 9ac47200b51cb09d2f15dbefa67e0412741d98aa.
>
>This commit fixes a bug in upstream commit a136f59c0a1f ("vb2: Move
>buffer cache synchronisation to prepare from queue") which isn't
>present in 4.9.
>
>So as a result you get an UNBALANCED message in the kernel log if
>this patch is applied:
>
>vb2: counters for queue ffffffc0f3687478, buffer 3: UNBALANCED!
>vb2: buf_init: 1 buf_cleanup: 1 buf_prepare: 805 buf_finish: 805
>vb2: buf_queue: 806 buf_done: 806
>vb2: alloc: 0 put: 0 prepare: 806 finish: 805 mmap: 0
>vb2: get_userptr: 0 put_userptr: 0
>vb2: attach_dmabuf: 1 detach_dmabuf: 1 map_dmabuf: 805 unmap_dmabuf: 805
>vb2: get_dmabuf: 0 num_users: 1609 vaddr: 0 cookie: 805
>
>Reverting this patch solves this regression.
>
>Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
I've queued both reverts to their respective branches, thank you.
--
Thanks,
Sasha
prev parent reply other threads:[~2018-11-24 6:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 11:43 [PATCH for v4.9] Revert "media: videobuf2-core: don't call memop 'finish' when queueing" Hans Verkuil
2018-11-23 19:52 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123195205.GL1917@sasha-vm \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox