Re: [PATCH 1/2] media: tegra-cec: Support Tegra186 and Tegra194

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1968 bytes --]

On Tue, Dec 11, 2018 at 10:26:14AM +0100, Hans Verkuil wrote:
> On 12/10/18 5:00 PM, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > The CEC controller found on Tegra186 and Tegra194 is the same as on
> > earlier generations.
> > 
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> >  drivers/media/platform/tegra-cec/tegra_cec.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/media/platform/tegra-cec/tegra_cec.c b/drivers/media/platform/tegra-cec/tegra_cec.c
> > index aba488cd0e64..8a1e10d008d0 100644
> > --- a/drivers/media/platform/tegra-cec/tegra_cec.c
> > +++ b/drivers/media/platform/tegra-cec/tegra_cec.c
> > @@ -472,6 +472,8 @@ static const struct of_device_id tegra_cec_of_match[] = {
> >  	{ .compatible = "nvidia,tegra114-cec", },
> >  	{ .compatible = "nvidia,tegra124-cec", },
> >  	{ .compatible = "nvidia,tegra210-cec", },
> > +	{ .compatible = "nvidia,tegra186-cec", },
> > +	{ .compatible = "nvidia,tegra194-cec", },
> >  	{},
> >  };
> >  
> > 
> 
> Applying: media: tegra-cec: Support Tegra186 and Tegra194
> WARNING: DT compatible string "nvidia,tegra186-cec" appears un-documented -- check ./Documentation/devicetree/bindings/
> #9: FILE: drivers/media/platform/tegra-cec/tegra_cec.c:475:
> +       { .compatible = "nvidia,tegra186-cec", },
> 
> WARNING: DT compatible string "nvidia,tegra194-cec" appears un-documented -- check ./Documentation/devicetree/bindings/
> #10: FILE: drivers/media/platform/tegra-cec/tegra_cec.c:476:
> +       { .compatible = "nvidia,tegra194-cec", },

Ugh... I usually have a git hook in place to catch this kind of mistake,
but it's currently disabled because it was getting in the way of some
large rebases I've been doing lately...

> I need an additional patch adding the new bindings to
> Documentation/devicetree/bindings/media/tegra-cec.txt.

Will send a patch right away.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]