From: Dan Carpenter <dan.carpenter@oracle.com>
To: Prashantha SP <prashanth.sp98@gmail.com>
Cc: sakari.ailus@linux.intel.com, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
mchehab@kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 3/3] Staging: media: ipu3: fixed max charecter style issue
Date: Mon, 28 Jan 2019 14:54:50 +0300 [thread overview]
Message-ID: <20190128115450.GF1795@kadam> (raw)
In-Reply-To: <20190127165416.13287-1-prashanth.sp98@gmail.com>
On Sun, Jan 27, 2019 at 10:24:16PM +0530, Prashantha SP wrote:
> fixed coding style issue.
>
> Signed-off-by: Prashantha SP <prashanth.sp98@gmail.com>
^^
Please use your full name that you would use to sign legal documents.
> ---
> drivers/staging/media/ipu3/ipu3-css.c | 178 ++++++++++++++------------
> 1 file changed, 94 insertions(+), 84 deletions(-)
>
> diff --git a/drivers/staging/media/ipu3/ipu3-css.c b/drivers/staging/media/ipu3/ipu3-css.c
> index 44c55639389a..466a1a8cc422 100644
> --- a/drivers/staging/media/ipu3/ipu3-css.c
> +++ b/drivers/staging/media/ipu3/ipu3-css.c
> @@ -186,7 +186,8 @@ static bool ipu3_css_queue_enabled(struct ipu3_css_queue *q)
> /******************* css hw *******************/
>
> /* In the style of writesl() defined in include/asm-generic/io.h */
> -static inline void writes(const void *mem, ssize_t count, void __iomem *addr)
> +static inline void writes(const void *mem, ssize_t count,
> + void __iomem *addr)
> {
> if (count >= 4) {
> const u32 *buf = mem;
> @@ -671,8 +672,9 @@ static void ipu3_css_pipeline_cleanup(struct ipu3_css *css, unsigned int pipe)
> ipu3_css_pool_cleanup(imgu, &css->pipes[pipe].pool.obgrid);
>
> for (i = 0; i < IMGU_ABI_NUM_MEMORIES; i++)
> - ipu3_css_pool_cleanup(imgu,
> - &css->pipes[pipe].pool.binary_params_p[i]);
> + ipu3_css_pool_cleanup
> + (imgu,
> + &css->pipes[pipe].pool.binary_params_p[i]);
The original is better.
regards,
dan carpenter
next prev parent reply other threads:[~2019-01-28 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 16:54 [PATCH 3/3] Staging: media: ipu3: fixed max charecter style issue Prashantha SP
2019-01-28 11:54 ` Dan Carpenter [this message]
2019-02-01 11:58 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128115450.GF1795@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=prashanth.sp98@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox