From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Sasha Levin <sashal@kernel.org>,
linux-media@vger.kernel.org, chiranjeevi.rapolu@intel.com,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/1] uvc: Avoid NULL pointer dereference at the end of streaming
Date: Fri, 1 Feb 2019 12:26:43 +0200 [thread overview]
Message-ID: <20190201102643.GC4341@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20190131073107.rogoi3rwmjgzq4x3@paasikivi.fi.intel.com>
Hello,
On Thu, Jan 31, 2019 at 09:31:07AM +0200, Sakari Ailus wrote:
> On Thu, Jan 31, 2019 at 02:04:48AM +0000, Sasha Levin wrote:
> > Hi,
> >
> > [This is an automated email]
> >
> > This commit has been processed because it contains a "Fixes:" tag,
> > fixing commit: 9c0863b1cc48 [media] vb2: call buf_finish from __queue_cancel.
> >
> > The bot has tested the following trees: v4.20.5, v4.19.18, v4.14.96, v4.9.153, v4.4.172, v3.18.133.
> >
> > v4.20.5: Build OK!
> > v4.19.18: Build OK!
> > v4.14.96: Build OK!
> > v4.9.153: Build OK!
> > v4.4.172: Build OK!
> > v3.18.133: Failed to apply! Possible dependencies:
> > 5d0fd3c806b9 ("[media] uvcvideo: Disable hardware timestamps by default")
> >
> >
> > How should we proceed with this patch?
>
> IMO 5d0fd3c806b9 should be applied as well. It's effectively a bugfix as
> well (but which also, for most users, covered the problem fixed by
> 9c0863b1cc48).
>
> Laurent, could you confirm?
That seems good to me.
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2019-02-01 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 10:09 [PATCH v2 1/1] uvc: Avoid NULL pointer dereference at the end of streaming Sakari Ailus
2019-01-31 2:04 ` Sasha Levin
2019-01-31 7:31 ` Sakari Ailus
2019-02-01 10:26 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201102643.GC4341@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=chiranjeevi.rapolu@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox