From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: hverkuil@xs4all.nl, mchehab@kernel.org, rajmohan.mani@intel.com
Subject: [PATCH 3/5] staging: imgu: Remove redundant checks
Date: Wed, 20 Feb 2019 13:19:51 +0200 [thread overview]
Message-ID: <20190220111953.7886-4-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20190220111953.7886-1-sakari.ailus@linux.intel.com>
Remove redundant checks for less than zero on unsigned variables.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/staging/media/ipu3/ipu3-css-fw.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/ipu3/ipu3-css-fw.c b/drivers/staging/media/ipu3/ipu3-css-fw.c
index 4122d4e42db6c..45aff76198e2c 100644
--- a/drivers/staging/media/ipu3/ipu3-css-fw.c
+++ b/drivers/staging/media/ipu3/ipu3-css-fw.c
@@ -200,13 +200,11 @@ int imgu_css_fw_init(struct imgu_css *css)
goto bad_fw;
for (j = 0; j < bi->info.isp.num_output_formats; j++)
- if (bi->info.isp.output_formats[j] < 0 ||
- bi->info.isp.output_formats[j] >=
+ if (bi->info.isp.output_formats[j] >=
IMGU_ABI_FRAME_FORMAT_NUM)
goto bad_fw;
for (j = 0; j < bi->info.isp.num_vf_formats; j++)
- if (bi->info.isp.vf_formats[j] < 0 ||
- bi->info.isp.vf_formats[j] >=
+ if (bi->info.isp.vf_formats[j] >=
IMGU_ABI_FRAME_FORMAT_NUM)
goto bad_fw;
--
2.11.0
next prev parent reply other threads:[~2019-02-20 11:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 11:19 [PATCH 0/5] Fix most ImgU driver compiler / checker warnings Sakari Ailus
2019-02-20 11:19 ` [PATCH 1/5] staging: imgu: Switch to __aligned() from __attribute__((aligned())) Sakari Ailus
2019-03-07 3:00 ` Tomasz Figa
2019-03-07 3:00 ` Tomasz Figa
2019-03-07 7:57 ` Sakari Ailus
2019-02-20 11:19 ` [PATCH 2/5] staging: imgu: Fix struct ipu3_uapi_awb_fr_config_s alignment Sakari Ailus
2019-05-27 16:39 ` Jacopo Mondi
2019-02-20 11:19 ` Sakari Ailus [this message]
2019-02-20 11:19 ` [PATCH 4/5] staging: imgu: Address compiler / checker warnings in MMU code Sakari Ailus
2019-02-20 11:19 ` [PATCH 5/5] Revert "media: ipu3: shut up warnings produced with W=1" Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220111953.7886-4-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rajmohan.mani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox